Conversation
|
/azp run |
rido-min
left a comment
There was a problem hiding this comment.
I'd like to include JWT support in the MqttConnectionSettings, at least we should use .env files to specify the hostname
My machine takes 5+ secs to acquire the token, there might be some optimizations we can make, and also test with a ManagedIdentity
Review how to refresh the token
Let's wait until we have the builtin roles
|
Please note additional improvements in the PBI as TODO. |
|
I'd like to do a quick test pass with the new builtin roles before merging. |
Do we need to block on this? In the spirit of iterative improvements on these samples, i would suggest we check it in, and put another item on our backlog to improve it based on the steps above. |
I'm pro merging it in, and have been for some time. There are readme instructions on how to use this -- the main improvement to be had is using the built-in roles that have been recently rolled out but don't currently work (as opposed to creating a custom role). |
|
this PR is blocked by dotnet/MQTTnet#1881 |
Adds sample with JWT authentication tied to a managed identity