Fix CreateFromEnvVars to allow '=' in env var value.#96
Open
briancr-ms wants to merge 1 commit intoAzure-Samples:mainfrom
Open
Fix CreateFromEnvVars to allow '=' in env var value.#96briancr-ms wants to merge 1 commit intoAzure-Samples:mainfrom
briancr-ms wants to merge 1 commit intoAzure-Samples:mainfrom
Conversation
Contributor
|
we need similar changes to all other languages |
Author
That's reasonable. What's the process for this repo? Do all language changes go into the same PR? Or should I create an issue for each language and resolve these through different PRs? |
Contributor
|
we are updating each sample in different PRs, before creating issues to track I'd like to understand the request. (keep in mind these are regular |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix issue #95. Read environment variables that contain an '=' in the value.
Checklist
mainbranch.mainbranch prior to submission and re-merged as needed after I took any feedback.Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Run MqttConnectionSettings unit tests.