Changes to variable names due to Flexible Server#31
Open
raahmed wants to merge 1 commit intoAzure-Samples:masterfrom
Open
Changes to variable names due to Flexible Server#31raahmed wants to merge 1 commit intoAzure-Samples:masterfrom
raahmed wants to merge 1 commit intoAzure-Samples:masterfrom
Conversation
Adding: SSL mode require. Removing: Full hostname.
mksuni
reviewed
Jun 23, 2021
| 'HOST': hostname + ".postgres.database.azure.com", | ||
| 'USER': os.environ['DBUSER'] + "@" + hostname, | ||
| 'PASSWORD': os.environ['DBPASS'] | ||
| 'HOST': os.environ['DBHOST'], |
There was a problem hiding this comment.
@raahmed Verify how the tutorial is written for this section. If we are stating to have DBHOST with severname and fully qualified name then we should revert back to 'HOST': hostname + ".postgres.database.azure.com" . Validate this with the tutorial please
Author
There was a problem hiding this comment.
The value of 'HOST' in the JSON output is the full name. To avoid confusion, I've changed the sample/tutorial so that it is a clear-cut copy-paste. Users get very confused and fail when they have to update the string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding:
SSL mode require.
Removing:
Full hostname.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information