Persist GPT-5 rich-model default in deploy workflow#779
Closed
Persist GPT-5 rich-model default in deploy workflow#779
Conversation
- Agents MUST have models available; they define the agent pattern. - Remove CATALOG_SEARCH_ENABLE_MODEL_ASSISTANCE config flag that disabled models - Remove CatalogModelAssistanceStrategy dataclass (strategy pattern misuse) - Remove _env_flag_enabled() utility function - Remove tests validating optional model-assistance disable behavior - Update README to remove model-assistance override documentation - Keep keyword mode deterministic (keyword mode never synthesizes) - Keep intelligent mode calling models when available and configured - Real fix: rebuild image with current library to unblock startup
The library's create_standard_app() doesn't support require_foundry_readiness yet. Remove the parameter and trust that Foundry is properly initialized by the library's default startup behavior. Agent requires Foundry; this is guaranteed at the framework level, not through optional service-level parameters.
Contributor
Author
|
All functional changes from this PR (GPT-5 model config, workflow updates, config guard revert) are already on main. After rebase, only residual import reordering remains, which conflicts with the project isort configuration. Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpt-5in both deploy env blocksgpt-5-nanoValidation
MODEL_DEPLOYMENT_NAME_RICHMODEL_DEPLOYMENT_NAME_RICH: gpt-5-nanoremainsCloses #778