Refactor Swagger UI and static file serving order#10
Open
spboyer wants to merge 1 commit intoAzure-Samples:mainfrom
Open
Refactor Swagger UI and static file serving order#10spboyer wants to merge 1 commit intoAzure-Samples:mainfrom
spboyer wants to merge 1 commit intoAzure-Samples:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a middleware ordering issue where Swagger UI was unable to load the OpenAPI specification file. The change reorders the middleware registration so that static file serving is configured before Swagger UI, allowing the openapi.yaml file to be properly served.
Changes:
- Reordered middleware registration to place UseStaticFiles before UseSwaggerUI
- Added a clarifying comment explaining the importance of this ordering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| app.UseStaticFiles(new StaticFileOptions | ||
| { | ||
| // Serve openapi.yaml file | ||
| ServeUnknownFileTypes = true, |
There was a problem hiding this comment.
Setting ServeUnknownFileTypes to true is a potential security risk as it allows serving files with any extension without proper MIME type validation. Consider using FileExtensionContentTypeProvider to explicitly allow only the .yaml extension instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Azure/azure-dev#647