demo: add mandatory version information to nodepool and cluster resources #4369
demo: add mandatory version information to nodepool and cluster resources #4369bennerv wants to merge 1 commit intoAzure:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennerv The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Adds explicit OpenShift version information to the demo Bicep resources for ARO-HCP clusters and nodepools, aligning the Bicep templates with the versioned API surface.
Changes:
- Add
properties.versionto the demo nodepool resource. - Add
properties.versionto the demo cluster resource.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| demo/bicep/nodepool.bicep | Adds a version block to the NodePool resource properties. |
| demo/bicep/cluster.bicep | Adds a version block to the HCP cluster resource properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rces in demo script Parameterize OpenShift versions in bicep templates instead of hardcoding them. Versions can be overridden via CLUSTER_VERSION and NODEPOOL_VERSION env vars. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bennerv
force-pushed
the
bvesel/specify-demo-script-install-version
branch
from
ecf4a8c to
2a5b840
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bennerv: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close in favor of: #4874 |
Prod now requires versions to be specified for nodepool and cluster resources. Add them in the nodepool and cluster bicep definitions for demo scripts to allow us to create clusters using them.