ARO-25999: add dormant ARO-RP monitoring lane#4844
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: swiencki The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Adds a dormant “ARO-RP” monitoring/alerting lane alongside existing SL/SRE/MSFT lanes, wiring it through the monitoring deployment so RP-owned alerts can be added later without further plumbing changes.
Changes:
- Introduces an RP observability config (
observability-rp.yaml) and Makefile wiring to generate a (currently no-op) RP Prometheus rules bicep output. - Extends monitoring infrastructure to provision an RP ICM Action Group and deploy an RP rules module.
- Updates configuration templates/schema/defaults to include the new
monitoring.icm.rpsettings.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tooling/prometheus-rules/Makefile | Adds run-rp target to generate rules from the RP observability config. |
| observability/observability-rp.yaml | New RP observability manifest pointing to generated RP rules output. |
| observability/Makefile | Wires RP generation/formatting into make alerts. |
| dev-infrastructure/templates/monitoring.bicep | Adds RP ICM params, passes them into actionGroups module, and deploys rp-rules.bicep. |
| dev-infrastructure/modules/metrics/rules/generatedRPPrometheusAlertingRules.bicep | Adds generated (no-op) RP alerting rules module output file. |
| dev-infrastructure/modules/metrics/rp-rules.bicep | New RP rules wrapper module referencing the generated RP alerting rules. |
| dev-infrastructure/modules/metrics/actiongroups.bicep | Adds an RP ICM Action Group resource and output. |
| dev-infrastructure/configurations/monitoring.tmpl.bicepparam | Adds RP parameters to the monitoring bicepparam template. |
| config/config.yaml | Adds default monitoring.icm.rp config subtree. |
| config/config.schema.json | Adds schema support for monitoring.icm.rp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Run `make materialize` to pick up the new RP IcM config keys added to config.yaml and config.schema.json.
|
@swiencki: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ARO-25999
Summary
Validation
go run ./tooling/prometheus-rules/... --config-file ./observability/observability-rp.yamlaz bicep build --file dev-infrastructure/templates/monitoring.bicepRelated