Skip to content

ARO-25999: add dormant ARO-RP monitoring lane#4844

Open
swiencki wants to merge 2 commits intomainfrom
arohcp-rp-queue
Open

ARO-25999: add dormant ARO-RP monitoring lane#4844
swiencki wants to merge 2 commits intomainfrom
arohcp-rp-queue

Conversation

@swiencki
Copy link
Copy Markdown
Collaborator

@swiencki swiencki commented Apr 10, 2026

ARO-25999

Summary

  • add an ARO-RP IcM action group and monitoring config alongside the existing SL/SRE/MSFT lanes
  • add a dedicated RP observability manifest, rules module, and generated no-op alerting file
  • wire the dormant RP lane into monitoring deployment for future RP-owned user-journey alerts

Validation

  • go run ./tooling/prometheus-rules/... --config-file ./observability/observability-rp.yaml
  • az bicep build --file dev-infrastructure/templates/monitoring.bicep

Related

Copilot AI review requested due to automatic review settings April 10, 2026 16:47
@openshift-ci openshift-ci bot requested review from geoberle and janboll April 10, 2026 16:47
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swiencki
Once this PR has been reviewed and has the lgtm label, please assign geoberle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dormant “ARO-RP” monitoring/alerting lane alongside existing SL/SRE/MSFT lanes, wiring it through the monitoring deployment so RP-owned alerts can be added later without further plumbing changes.

Changes:

  • Introduces an RP observability config (observability-rp.yaml) and Makefile wiring to generate a (currently no-op) RP Prometheus rules bicep output.
  • Extends monitoring infrastructure to provision an RP ICM Action Group and deploy an RP rules module.
  • Updates configuration templates/schema/defaults to include the new monitoring.icm.rp settings.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tooling/prometheus-rules/Makefile Adds run-rp target to generate rules from the RP observability config.
observability/observability-rp.yaml New RP observability manifest pointing to generated RP rules output.
observability/Makefile Wires RP generation/formatting into make alerts.
dev-infrastructure/templates/monitoring.bicep Adds RP ICM params, passes them into actionGroups module, and deploys rp-rules.bicep.
dev-infrastructure/modules/metrics/rules/generatedRPPrometheusAlertingRules.bicep Adds generated (no-op) RP alerting rules module output file.
dev-infrastructure/modules/metrics/rp-rules.bicep New RP rules wrapper module referencing the generated RP alerting rules.
dev-infrastructure/modules/metrics/actiongroups.bicep Adds an RP ICM Action Group resource and output.
dev-infrastructure/configurations/monitoring.tmpl.bicepparam Adds RP parameters to the monitoring bicepparam template.
config/config.yaml Adds default monitoring.icm.rp config subtree.
config/config.schema.json Adds schema support for monitoring.icm.rp.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread config/config.yaml
Run `make materialize` to pick up the new RP IcM config keys
added to config.yaml and config.schema.json.
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 16, 2026

@swiencki: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cspr 85764a7 link true /test cspr

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants