Skip to content

chore: add e2e test for eventhub as a destination for shoebox diagnostic logs#4863

Open
ashishmax31 wants to merge 1 commit intomainfrom
shoebox-eventhub-e2e
Open

chore: add e2e test for eventhub as a destination for shoebox diagnostic logs#4863
ashishmax31 wants to merge 1 commit intomainfrom
shoebox-eventhub-e2e

Conversation

@ashishmax31
Copy link
Copy Markdown
Collaborator

@ashishmax31 ashishmax31 commented Apr 13, 2026

This PR modifies the existing shoebox e2e test to also include azure eventhub as a destination for shoebox diagnostic logs

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ashishmax31
Copy link
Copy Markdown
Collaborator Author

ashishmax31 commented Apr 13, 2026

/test stage-e2e-parallel

@ashishmax31 ashishmax31 force-pushed the shoebox-eventhub-e2e branch from 2dd1726 to 1d99d0f Compare April 13, 2026 15:27
@ashishmax31
Copy link
Copy Markdown
Collaborator Author

ashishmax31 commented Apr 13, 2026

Keeping it draft because i'm waiting for stage e2e to pass.

ashishmax31
ashishmax31 commented Apr 13, 2026
View reviewed changes
Comment thread test/cmd/aro-hcp-tests/main.go Outdated

// Specs can be globally filtered...
// specs = specs.MustFilter([]string{`name.contains("filter")`})
specs = specs.MustFilter([]string{`name.contains("shoebox")`})
Copy link
Copy Markdown
Collaborator Author

@ashishmax31 ashishmax31 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this filter for quick feedback from stage e2e. Will remove once stage e2e passes.

@ashishmax31
Copy link
Copy Markdown
Collaborator Author

ashishmax31 commented Apr 14, 2026

/test stage-e2e-parallel

@ashishmax31 ashishmax31 force-pushed the shoebox-eventhub-e2e branch from 1d99d0f to 08fcc63 Compare April 14, 2026 11:46
@ashishmax31
Copy link
Copy Markdown
Collaborator Author

ashishmax31 commented Apr 14, 2026

/test stage-e2e-parallel

@ashishmax31 ashishmax31 force-pushed the shoebox-eventhub-e2e branch from 08fcc63 to df47717 Compare April 14, 2026 13:10
@ashishmax31 ashishmax31 marked this pull request as ready for review April 14, 2026 13:10
@openshift-ci openshift-ci bot requested review from deads2k and miquelsi April 14, 2026 13:10
@ashishmax31 ashishmax31 force-pushed the shoebox-eventhub-e2e branch from df47717 to 701d368 Compare April 14, 2026 13:20
@ashishmax31 ashishmax31 requested a review from janboll April 14, 2026 13:24
@ashishmax31 ashishmax31 force-pushed the shoebox-eventhub-e2e branch 2 times, most recently from 0035a34 to 34bd9b2 Compare April 14, 2026 13:56
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashishmax31
Once this PR has been reviewed and has the lgtm label, please assign bennerv for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashishmax31 ashishmax31 force-pushed the shoebox-eventhub-e2e branch from 34bd9b2 to 5c011c8 Compare April 14, 2026 13:58
@ashishmax31
Copy link
Copy Markdown
Collaborator Author

ashishmax31 commented Apr 14, 2026

/test e2e-parallel

3 similar comments
@ashishmax31
Copy link
Copy Markdown
Collaborator Author

ashishmax31 commented Apr 15, 2026

/test e2e-parallel

@ashishmax31
Copy link
Copy Markdown
Collaborator Author

ashishmax31 commented Apr 15, 2026

/test e2e-parallel

@ashishmax31
Copy link
Copy Markdown
Collaborator Author

ashishmax31 commented Apr 15, 2026

/test e2e-parallel

@ashishmax31
chore: add e2e test for eventhub as a destination for shoebox diagnos…
2c1b140 
…tic logs

Signed-off-by: Ashish <asnaraya@redhat.com>
@ashishmax31 ashishmax31 force-pushed the shoebox-eventhub-e2e branch from 5c011c8 to 2c1b140 Compare April 16, 2026 06:02
janboll
janboll reviewed Apr 16, 2026
View reviewed changes
Comment thread test/e2e/shoebox_logs.go
Comment on lines +198 to +199
AuthorizationRuleID: *authRuleResp.ID,
ConnectionString: *keysResp.PrimaryConnectionString,
Copy link
Copy Markdown
Collaborator

@janboll janboll Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for nil

Comment thread test/e2e/shoebox_logs.go
func pollVerifier(ctx context.Context, name string, verifier shoeboxLogVerifier, timeout time.Duration) bool {
ticker := time.NewTicker(60 * time.Second)
defer ticker.Stop()
timer := time.After(timeout)
Copy link
Copy Markdown
Collaborator

@janboll janboll Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timer is never cancelled if the context completes first. Use context.WithTimeout instead.

Copy link
Copy Markdown
Collaborator Author

@ashishmax31 ashishmax31 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is unecessary from go 1.23. From go doc:
"Before Go 1.23, this documentation warned that the underlying Timer would not be recovered by the garbage collector until the timer fired, and that if efficiency was a concern, code should use NewTimer instead and call Timer.Stop if the timer is no longer needed. As of Go 1.23, the garbage collector can recover unreferenced, unstopped timers."

Comment thread test/e2e/shoebox_logs.go
func createEventHub(ctx context.Context, subscriptionID string, creds azcore.TokenCredential, resourceGroupName, location string) (*eventHubResult, error) {
const (
namespaceName = "shoebox-eh-ns"
hubName = "shoebox-eh"
Copy link
Copy Markdown
Collaborator

@janboll janboll Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be randomized?

Copy link
Copy Markdown
Collaborator Author

@ashishmax31 ashishmax31 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to randomize this as they are scoped under a RG (and the RG is randomized)

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 16, 2026

@ashishmax31: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cspr 2c1b140 link true /test cspr
ci/prow/images-push 2c1b140 link true /test images-push

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 16, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janboll janboll janboll left review comments

@deads2k deads2k Awaiting requested review from deads2k

@miquelsi miquelsi Awaiting requested review from miquelsi

Assignees

No one assigned

Labels

needs-rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashishmax31 @janboll