istio: bump istio for swft envs to asm-1-28 target#4865
istio: bump istio for swft envs to asm-1-28 target#4865
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dev-environment Istio revision defaults to asm-1-28 so swift/dev deployments don’t fail in regions where asm-1-26 is no longer available.
Changes:
- Bump dev SVC Istio
targetVersiontoasm-1-28and removeasm-1-26from the supportedversionslist. - Remove redundant per-environment dev overrides now covered by the shared dev default.
- Refresh Helm template snapshot fixtures to reflect the single Istio revision.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
config/config.yaml |
Updates dev Istio defaults to asm-1-28 and removes now-redundant overrides. |
config/rendered/dev/swft/uksouth.yaml |
Rendered dev swift config reflects new Istio target/version set. |
config/rendered/dev/perf/westus3.yaml |
Rendered dev perf config reflects new Istio target/version set. |
config/rendered/dev/dev/westus3.yaml |
Rendered dev config reflects new Istio target/version set. |
config/rendered/dev/cspr/westus3.yaml |
Rendered dev cspr config reflects new Istio target/version set. |
istio/testdata/zz_fixture_TestHelmTemplate_istio_mise_enabled.yaml |
Snapshot updated to no longer emit asm-1-26 revision resources. |
dev-infrastructure/zz_fixture_TestHelmTemplate_dev_westus3_svc_1_istio.yaml |
Snapshot updated to no longer emit asm-1-26 revision resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bennerv
force-pushed
the
bvesel/bump-istio-rev-to-asm-1-28
branch
from
967ca38 to
2a3a880
Compare
bennerv
force-pushed
the
bvesel/bump-istio-rev-to-asm-1-28
branch
from
2a3a880 to
a7e90b7
Compare
bennerv
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennerv, trevorwilliams2025 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test verify |
|
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/test e2e-parallel |
|
/retest |
|
@bennerv: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What
Broken swift environments which don't have istio asm-1-28 revision defined.
Why
We need to continuously upgrade istio to ensure it's not out of support. This should not impact any INT/Stage/Prod envs as they have their own defaults defined in config in sdp-pipelines.
Swift environment is treated as ephemeral. Therefore, we should update this to 1-28. Trevor is working on updating non-ephemeral (perf, dev, cspr) using canary upgrades.
Testing
Ran
DEPLOY_ENV=swft make entrypoint/Regionlocally.Note:
Since this is just updating dev environments, I have no problem changing
targetVersionat the same time I remove the older version, even though they happen in order.If this were to apply itself to an int/stage/prod environment as is, i believe there would be downtime on our istio external gateway because we remove the version we're actively using.
In dev envs, it's not a big deal since it should just work if you're upgrading.