e2e resource group cleanup: use rg-ordered workflow and make "no-rp" mode best-effort#4873
e2e resource group cleanup: use rg-ordered workflow and make "no-rp" mode best-effort#4873
Conversation
a2c6102 to
d2b7f97
Compare
d2b7f97 to
8b1ab0f
Compare
Grant the release bot the Graph directory read permission needed for orphaned role assignment discovery and treat per-target delete authorization failures as best effort so one forbidden assignment does not fail the whole sweep. Made-with: Cursor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rg-ordered workflow and make no-rp best-effort|
@roivaz: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Replace the ad-hoc
DeleteResourceGroupcalls in e2e cleanup with thecleanup-sweeper'srg-orderedworkflow, and let callers control whether deletion errors are fatal.Changes:
standardandno-rpcleanup modes now userunOrderedResourceGroupCleanup, which runsResourceGroupOrderedCleanupWorkflowfrom thecleanup-sweeperengine. This removes direct use ofDeleteResourceGroup,resourceClientFactory, andnetworkClientFactoryfrom the cleanup paths.ContinueOnErroradded toWorkflowOptions: Steps in the ordered workflow now useopts.ContinueOnErrorinstead of hardcodingtrue, letting callers choose between strict and best-effort behavior.standardmode (ContinueOnError: false,Wait: true): Deletion failures abort the workflow and fail the job — correct for int/stg/prod where cleanup issues need immediate visibility.no-rpmode (ContinueOnError: true,Wait: false): Per-target deletion failures are logged and skipped inside the engine. Discovery errors still propagate since they indicate broken code. Deletions are fire-and-forget.cleanup-sweeperandtemplatizecallers explicitly passContinueOnError: trueto preserve their best-effort behavior.cleanup-sweeperas a dependency of thetestmodule.