ARO-25801: consolidate LLM workflow rules and local integration guidance#4739
Open
tuxerrante wants to merge 4 commits intomasterfrom
Open
ARO-25801: consolidate LLM workflow rules and local integration guidance#4739tuxerrante wants to merge 4 commits intomasterfrom
tuxerrante wants to merge 4 commits intomasterfrom
Conversation
…ance Consolidate reusable Cursor rules and local integration testing instructions into a single team-focused change set. Keep Linux/Fedora as the default workflow, isolate macOS guidance, and document canonical docs references to reduce configuration drift. Made-with: Cursor
tuxerrante
requested review from
alcasim,
bennerv,
cadenmarchese,
hawkowl,
hlipsig,
jharrington22,
kevinobriendotca,
kimorris27,
mociarain,
mrWinston,
rogbas,
sankur-codes,
tiguelu,
tsatam,
ventifus,
wanghaoran1988 and
yjst2012
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a team-wide .cursor/ baseline: reusable Cursor rules for worktree isolation, safety/approval rails, validation workflow, PR hygiene, and code review focus areas, plus a “local integration testing” skill to standardize how developers validate admin API/E2E flows against the containerized dev environment.
Changes:
- Added multiple
.cursor/rules/*.mdcrule documents covering worktrees, validation pipeline, safety rails, PR lifecycle, multi-module Go pitfalls, Makefile-first workflow, and code style/review checklists. - Added
.cursor/skills/local-integration-testing/SKILL.mdwith Linux-first local RP + focused E2E guidance, plus macOS notes and troubleshooting pointers. - Linked guidance back to canonical
docs/pages to reduce drift.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| .cursor/skills/local-integration-testing/SKILL.md | New Linux-first playbook for running the containerized dev RP and executing focused E2E/admin API verification. |
| .cursor/rules/worktree-isolation.mdc | New rule enforcing isolated worktrees and host checkout hygiene. |
| .cursor/rules/validation-pipeline.mdc | New ordered “fmt → lint → unit → full” validation guidance aligned to Makefile targets. |
| .cursor/rules/safety-rails.mdc | New safety/approval gates and architecture invariants for sensitive operations. |
| .cursor/rules/pr-lifecycle.mdc | New rule for PR creation, CI monitoring, and merge flow. |
| .cursor/rules/multi-module-awareness.mdc | New rule documenting the root vs pkg/api Go module split and related test/build pitfalls. |
| .cursor/rules/makefile-first.mdc | New rule emphasizing Makefile targets as the canonical interface for dev/CI workflows. |
| .cursor/rules/code-style.mdc | New rule documenting CI-enforced formatting/import/error-handling conventions. |
| .cursor/rules/code-review.mdc | New Go-focused review checklist rule (globs **/*.go). |
| .cursor/rules/clean-history.mdc | New rule for keeping linear history and clean commits before PR submission. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Align branch examples with master, harden worktree env linking guidance, and make local integration commands runtime-appropriate for Linux and macOS. Made-with: Cursor
Collaborator
|
Should we consolidate all the discussions around the usage of agents in the feature repo in the architecture PR:https://github.com/openshift-online/architecture/pull/71 ?? I believe we should have a common agreed plan to move forward with any agentic code merging in the feature repos. |
Document the minimal env sourcing and existing-cluster flags needed to run e2e reliably from a worktree so contributors avoid unset variable failures and unnecessary create/delete cycles. Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add pre-push and reviewer gate rules from recent PR lessons, and align existing workflow docs with current repo behavior (module lint scope, controller count drift, and required E2E env vars) to close outstanding review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.cursor/rulesbaseline for worktree isolation, safety rails, validation pipeline, clean history, PR lifecycle, and code review/style guidance..cursor/skills/local-integration-testing/SKILL.mdwith Linux/Fedora-first instructions, separate macOS notes, and references to canonicaldocs/pages to reduce drift..cursor/rules/pre-push-gates.mdc(branch/worktree checks, typed API usage, error/logging/streaming checks).cursor/rules/review-gates.mdc(review checklist for type safety, error contract, logging consistency, concurrency/cleanup, and test depth)safety-railspkg/apilint scope inmakefile-firstpkg/apilint step invalidation-pipelineRESOURCEGROUPin worktree E2E env validation indocs/testing.mdTest plan
Made with Cursor