Skip to content

[ARO-1542] Implement Azure SDK clients in MIMO Actuator#4761

Merged
hawkowl merged 15 commits intomasterfrom
hawkowl/ARO-23471-3
Apr 15, 2026
Merged

[ARO-1542] Implement Azure SDK clients in MIMO Actuator#4761
hawkowl merged 15 commits intomasterfrom
hawkowl/ARO-23471-3

Conversation

@hawkowl
Copy link
Copy Markdown
Collaborator

@hawkowl hawkowl commented Apr 9, 2026

Which issue this PR addresses:

Part of ARO-1542

What this PR does / why we need it:

Implements the ability for MIMO tasks to use Azure clients through a single source. Clients are only generated when they are used.

Test plan for issue:

This code is currently unused but will be tested by parts of ARO-1542 and ARO-23471.

Is there any documentation that needs to be updated for this PR?

Existing documentation covers how to access items on the TaskContext.

How do you know this will function as expected in production?

N/A

@hawkowl hawkowl added size-small Size small ready-for-review go Pull requests that update Go code labels Apr 9, 2026
Copilot AI review requested due to automatic review settings April 9, 2026 04:18
@hawkowl hawkowl added the skippy pull requests raised by member of Team Skippy label Apr 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Azure Track 2 SDK client access to the MIMO Actuator task context so tasks can lazily obtain Azure clients from a single place, and updates actuator plumbing/tests to include subscription context.

Changes:

  • Extend mimo.TaskContext to expose Azure Track 2 SDK client getters (network/compute/ACR) and wire lazy client creation into the actuator task context.
  • Plumb SubscriptionDocument access through the actuator/service so tenant-aware credentials can be created per cluster subscription.
  • Update MIMO step/actuator tests and fake test contexts to use the new task context shape.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/mimo/tasks/testcontext.go Expands fake TaskContext to support Azure client getters and subscription/cluster docs.
pkg/util/mimo/taskcontext.go Extends TaskContext interface with Azure client getters; tweaks type assertion error message.
pkg/util/acrtoken/acrtoken.go Adds an additional ACR token manager constructor.
pkg/mimo/steps/cluster/tls_test.go Updates tests to pass OpenShiftClusterDocument into fake context.
pkg/mimo/steps/cluster/msi_test.go Updates tests to pass OpenShiftClusterDocument into fake context.
pkg/mimo/steps/cluster/mdsd_test.go Updates tests to pass OpenShiftClusterDocument into fake context.
pkg/mimo/steps/cluster/acrtoken_checker_test.go Updates tests to pass OpenShiftClusterDocument into fake context.
pkg/mimo/actuator/task.go Extends actuator task context to carry subscription doc and Azure client cache.
pkg/mimo/actuator/task_azure.go Introduces lazy initialization for Azure Track 2 SDK clients using FP cert creds.
pkg/mimo/actuator/service.go Fetches Subscriptions DB and passes it into the actuator.
pkg/mimo/actuator/service_test.go Updates service tests/fixtures to include subscription docs and DB group wiring.
pkg/mimo/actuator/manager.go Fetches subscription doc during processing and passes it into task contexts; adjusts return value to reflect actual work done.
pkg/mimo/actuator/actuator_test.go Updates actuator tests to include subscription fixtures and adds coverage for missing subscription.
cmd/aro/mimoactuator.go Wires Subscriptions DB into the MIMO actuator command startup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/mimo/tasks/testcontext.go Outdated
Comment thread pkg/util/mimo/taskcontext.go
Comment thread pkg/mimo/actuator/task_azure.go
Comment thread pkg/util/acrtoken/acrtoken.go Outdated
Copilot AI review requested due to automatic review settings April 10, 2026 02:03
@hawkowl hawkowl force-pushed the hawkowl/ARO-23471-3 branch from 83d9387 to b4bfb8f Compare April 10, 2026 02:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/mimo/actuator/task.go Outdated
Comment thread pkg/mimo/actuator/manager.go
Comment thread pkg/mimo/actuator/manager.go
Comment thread pkg/mimo/actuator/task_azure.go
@hawkowl hawkowl force-pushed the hawkowl/ARO-23471-3 branch from b4bfb8f to 2fc8f94 Compare April 13, 2026 03:23
Copy link
Copy Markdown
Collaborator

@wanghaoran1988 wanghaoran1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

Copy link
Copy Markdown
Collaborator

@wanghaoran1988 wanghaoran1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two inline review comments.

Comment thread pkg/mimo/actuator/task_azure_test.go
Comment thread pkg/util/mimo/taskcontext.go
Copilot AI review requested due to automatic review settings April 14, 2026 02:58
@hawkowl hawkowl force-pushed the hawkowl/ARO-23471-3 branch from 2fc8f94 to db54db0 Compare April 14, 2026 02:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/mimo/actuator/task_azure_test.go
Comment thread pkg/mimo/actuator/task_azure.go
@hawkowl
Copy link
Copy Markdown
Collaborator Author

hawkowl commented Apr 14, 2026

/azp run ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@hawkowl hawkowl merged commit f131c38 into master Apr 15, 2026
31 checks passed
@hawkowl hawkowl deleted the hawkowl/ARO-23471-3 branch April 15, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code ready-for-review size-small Size small skippy pull requests raised by member of Team Skippy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants