-
Notifications
You must be signed in to change notification settings - Fork 6
Audience parameter support #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
linglingye001
wants to merge
2
commits into
release/v2.6.0
Choose a base branch
from
linglingye/audience-support
base: release/v2.6.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package loader | ||
|
|
||
| import ( | ||
| "azappconfig/provider/internal/properties" | ||
| "fmt" | ||
| "os" | ||
| "testing" | ||
|
|
||
| azappconfig "github.com/Azure/azure-sdk-for-go/sdk/data/azappconfig/v2" | ||
| ) | ||
|
|
||
| func TestNewClientOptions(t *testing.T) { | ||
| expectedAppID := fmt.Sprintf("%s/%s", properties.ModuleName, properties.ModuleVersion) | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| envVars map[string]string | ||
| expectedAudience string | ||
| hasCloudConfig bool | ||
| }{ | ||
| { | ||
| name: "no audience set - default behavior", | ||
| envVars: nil, | ||
| expectedAudience: "", | ||
| hasCloudConfig: false, | ||
| }, | ||
| { | ||
| name: "audience set to Azure Government", | ||
| envVars: map[string]string{ | ||
| AzureAppConfigAudience: "https://appconfig.azure.us", | ||
| }, | ||
| expectedAudience: "https://appconfig.azure.us", | ||
| hasCloudConfig: true, | ||
| }, | ||
| { | ||
| name: "audience set to Azure China", | ||
| envVars: map[string]string{ | ||
| AzureAppConfigAudience: "https://appconfig.azure.cn", | ||
| }, | ||
| expectedAudience: "https://appconfig.azure.cn", | ||
| hasCloudConfig: true, | ||
| }, | ||
| { | ||
| name: "audience set to empty string", | ||
| envVars: map[string]string{ | ||
| AzureAppConfigAudience: "", | ||
| }, | ||
| expectedAudience: "", | ||
| hasCloudConfig: false, | ||
| }, | ||
| { | ||
| name: "audience set to custom value", | ||
| envVars: map[string]string{ | ||
| AzureAppConfigAudience: "https://custom.audience.example", | ||
| }, | ||
| expectedAudience: "https://custom.audience.example", | ||
| hasCloudConfig: true, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // Clean up the env var before each test | ||
| if err := os.Unsetenv(AzureAppConfigAudience); err != nil { | ||
| t.Fatalf("Failed to unset environment variable: %v", err) | ||
| } | ||
|
|
||
| // Setup environment variables | ||
| if tt.envVars != nil { | ||
| for k, v := range tt.envVars { | ||
| if err := os.Setenv(k, v); err != nil { | ||
| t.Fatalf("Failed to set environment variable: %v", err) | ||
| } | ||
| defer func(key string) { | ||
| if err := os.Unsetenv(key); err != nil { | ||
| t.Errorf("Failed to unset environment variable: %v", err) | ||
| } | ||
| }(k) | ||
| } | ||
| } | ||
|
|
||
| options := newClientOptions() | ||
|
|
||
| // Verify telemetry ApplicationID is always set | ||
| if options.ClientOptions.Telemetry.ApplicationID != expectedAppID { | ||
| t.Errorf("Expected ApplicationID %q, got %q", expectedAppID, options.ClientOptions.Telemetry.ApplicationID) | ||
| } | ||
|
|
||
| // Verify cloud configuration / audience | ||
| if tt.hasCloudConfig { | ||
| serviceConfig, exists := options.ClientOptions.Cloud.Services[azappconfig.ServiceName] | ||
| if !exists { | ||
| t.Fatal("Expected cloud service configuration to be set for azappconfig.ServiceName, but it was not found") | ||
| } | ||
| if serviceConfig.Audience != tt.expectedAudience { | ||
| t.Errorf("Expected audience %q, got %q", tt.expectedAudience, serviceConfig.Audience) | ||
| } | ||
| } else { | ||
| if len(options.ClientOptions.Cloud.Services) != 0 { | ||
| t.Errorf("Expected no cloud service configuration, but got %v", options.ClientOptions.Cloud.Services) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about put it into
envsection and name it "azureAppconfigAudience"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use full product name. If put it to the
envsection , the command will be--set env.azureAppConfigurationAudience, what do you think? @zhenlanThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one is more consistent with existing naming conventions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helm best practice recommended camelCase, and
azureAppConfigurationAudienceis more descriptive, consistent with howazureClientIdandazureTenantIdare already done.