Update allowed values and default values to title case to match the p…#296
Update allowed values and default values to title case to match the p…#296jeevanions wants to merge 1 commit intoAzure:mainfrom
Conversation
…olicies Update allowed values and default values to title case to match the policies CosmosCMKEffect: audit/deny/disabled → Audit/Deny/Disabled, default deny → Deny HealthcareAPIsCMKEffect: audit/disabled → Audit/Disabled, default audit → Audit StreamAnalyticsCMKEffect: audit/deny/disabled → Audit/Deny/Disabled, default deny → Deny botServiceCmk: removed duplicate lowercase entries (audit/deny/disabled), kept Audit/Deny/Disabled
@microsoft-github-policy-service agree |
|
Hi @jeevanions. Thanks for raising this PR. At this time the library is synced from the enterprise-scale repo: https://github.com/Azure/Enterprise-Scale/tree/main/src/resources/Microsoft.Authorization/policySetDefinitions As such the policy set definitions would need to be updated there first. If you can raise an issue for this over at https://github.com/Azure/Azure-Landing-Zones/issues, we can triage the problem. You are welcome to raise the PR on the enterprise-scale repo in the meantime, but we will need to understand the 'why' behind this change. What issue are you seeing? What error messages are you getting? Are you using Terraform or Bicep, etc... CC: @matt-FFFFFF, @jtracey93, @oZakari in case any you are already aware of this or an existing issue for it. |
|
It looks similar to this issue where the newer built-in policy definition removed the lowercase effect values and now only accepts uppercase values. I checked the definitions though for this one and looks like they are still backward compatible with the lowercase effect names. @jeevanions if you can confirm what you're seeing in an issue: https://github.com/Azure/Azure-Landing-Zones/issues that would be appreciated. |
CosmosCMKEffect:audit/deny/disabled→Audit/Deny/Disabled, defaultdeny→DenyHealthcareAPIsCMKEffect:audit/disabled→Audit/Disabled, defaultaudit→AuditStreamAnalyticsCMKEffect:audit/deny/disabled→Audit/Deny/Disabled, defaultdeny→DenybotServiceCmk: removed duplicate lowercase entries (audit/deny/disabled), keptAudit/Deny/Disabled