Conversation
shahneerali
reviewed
Feb 13, 2026
| } | ||
|
|
||
| pub fn get_log_folder(&self) -> String { | ||
| match misc_helpers::resolve_env_variables(&self.logFolder) { |
Contributor
There was a problem hiding this comment.
why do we remove match? misc_helpers::resolve_env_variables doesn't contain match, it returns prev val
shahneerali
requested changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regex::Newis performance-sensitive - useLazyLockto compile it only once as a static regex and reuse it for subsequent callssearch_filesshould not create a new regex instance each time, and the caller should cache the regex if it is used frequently.get_xxxin Config invokedresolve_env_variablesat each call - resolve all the config values at new when first read & parse our config file.regex.replace_all's time-complexity isO(m * n^2)inredact_secrets- first check for indicators, just simple substrings to check for before running the more expensive regexes.