perf improvement: remove hyper_client::host_port_from_uri#318
Open
ZhidongPeng wants to merge 1 commit intoAzure:devfrom
Open
perf improvement: remove hyper_client::host_port_from_uri#318ZhidongPeng wants to merge 1 commit intoAzure:devfrom
ZhidongPeng wants to merge 1 commit intoAzure:devfrom
Conversation
…om UrI multiple times
ZhidongPeng
changed the title
shahneerali
reviewed
Feb 13, 2026
| Ipv4Addr::LOCALHOST.to_string(), | ||
| self.port, | ||
| PROVISION_URL_PATH | ||
| PROVISION_URL_PATH, |
shahneerali
reviewed
Feb 13, 2026
| (format!("http://{}/", constants::WIRE_SERVER_IP)) | ||
| .parse() | ||
| .unwrap(), | ||
| constants::WIRE_SERVER_IP.to_string(), |
Contributor
There was a problem hiding this comment.
what is 80 in this case?
shahneerali
reviewed
Feb 13, 2026
| } | ||
|
|
||
| const IMDS_URI: &str = "metadata/instance?api-version=2018-02-01"; | ||
| const IMDS_URI: &str = "/metadata/instance?api-version=2018-02-01"; |
Contributor
There was a problem hiding this comment.
need to validate this with UT
shahneerali
reviewed
Feb 13, 2026
|
|
||
| const TELEMETRY_DATA_URI: &str = "machine/?comp=telemetrydata"; | ||
| const GOALSTATE_URI: &str = "machine?comp=goalstate"; | ||
| const TELEMETRY_DATA_URI: &str = "/machine/?comp=telemetrydata"; |
Contributor
There was a problem hiding this comment.
again need tests for this change
shahneerali
reviewed
Feb 13, 2026
| } | ||
| }; | ||
| let default_port = if uri.scheme_str() == Some("https") { | ||
| 443 |
Contributor
There was a problem hiding this comment.
let's make constants for these
shahneerali
reviewed
Feb 13, 2026
| let default_port = if uri.scheme_str() == Some("https") { | ||
| 443 | ||
| } else { | ||
| 80 |
shahneerali
requested changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse Host & Port from UrI multiple times per each proxied requests - Removed host_port_from_uri(full_url: &Uri) and added struct HostEndpoint with host, port and path_and_query