Enhancements to airlock functions#206
Merged
SvenAelterman merged 10 commits intoSep 12, 2025
Merged
Conversation
…cess is disabled Fixes #205
…rage account Add additional ADF pipeline to move from File Share to File Share Add `airlockProcessNotificationEmail` parameter for future use Modify Logic App parameter names for increased readability
…on of airlock export request
Collaborator
Author
|
Also closes #203 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the airlock functionality by adding support for file rejection workflows, notification systems, and improved pipeline management. The changes introduce a new process notification email parameter for principal investigators and refactor pipeline naming for better organization.
Key changes:
- Added support for rejection workflows that move files back to a private file share
- Introduced process notification emails for principal investigators separate from approver emails
- Refactored pipeline names into a structured type system for better maintainability
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shared-modules/types/pipelineNamesType.bicep | Defines a new type for structured pipeline naming |
| research-spoke/spoke-modules/airlock/main.bicep | Updates airlock module to support new notification parameter and pipeline structure |
| research-spoke/spoke-modules/airlock/logicApp.bicep | Enhances logic app with additional parameters for rejection workflows |
| research-spoke/spoke-modules/airlock/content/logicAppWorkflow.json | Implements complete rejection workflow with PI notifications |
| research-spoke/spoke-modules/airlock/content/adfPipeline-Files2Files.json | Adds new pipeline for file-to-file transfers |
| research-spoke/spoke-modules/airlock/adf.bicep | Updates ADF module to support new pipeline structure |
| research-spoke/main.bicep | Adds process notification email parameter |
| research-hub/main.bicep | Fixes dependency issue in disk encryption set module |
| research-hub/deploy.ps1 | Fixes variable name typo |
| .vscode/settings.json | Adds new spell check words |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vbalbarin
approved these changes
Sep 12, 2025
SvenAelterman
deleted the
202-if-reviewer-denies-export-request-move-file-back-to-enclave-storage-enclave
branch
September 12, 2025 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205