Add sender (From) email address parameter for airlock emails#213
Merged
SvenAelterman merged 2 commits intoNov 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable sender (From) email address parameter for emails sent by the airlock Logic App, allowing administrators to specify a custom "From" field for all outgoing notifications.
Key changes:
- Added a new
fromEmailparameter that propagates through the infrastructure modules - Updated the Logic App workflow to use the new parameter in all email notifications
- Maintained backward compatibility with a default empty string value
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| research-spoke/main.bicep | Adds the top-level airlockFromEmail parameter and passes it to the airlock module |
| research-spoke/spoke-modules/airlock/main.bicep | Adds fromEmail parameter and forwards it to the Logic App module |
| research-spoke/spoke-modules/airlock/logicApp.bicep | Accepts fromEmail parameter and passes it to the Logic App workflow |
| research-spoke/spoke-modules/airlock/content/logicAppWorkflow.json | Updates all email actions to include the configurable "From" field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SvenAelterman
marked this pull request as draft
September 17, 2025 15:27
…o-be-sent-on-behalf-of
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SvenAelterman
deleted the
211-allow-regular-emails-sent-by-logic-app-to-be-sent-on-behalf-of
branch
November 14, 2025 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.