Skip to content

Add sender (From) email address parameter for airlock emails#213

Merged
SvenAelterman merged 2 commits into
mainfrom
211-allow-regular-emails-sent-by-logic-app-to-be-sent-on-behalf-of
Nov 14, 2025
Merged

Add sender (From) email address parameter for airlock emails#213
SvenAelterman merged 2 commits into
mainfrom
211-allow-regular-emails-sent-by-logic-app-to-be-sent-on-behalf-of

Conversation

@SvenAelterman

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a configurable sender (From) email address parameter for emails sent by the airlock Logic App, allowing administrators to specify a custom "From" field for all outgoing notifications.

Key changes:

  • Added a new fromEmail parameter that propagates through the infrastructure modules
  • Updated the Logic App workflow to use the new parameter in all email notifications
  • Maintained backward compatibility with a default empty string value

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
research-spoke/main.bicep Adds the top-level airlockFromEmail parameter and passes it to the airlock module
research-spoke/spoke-modules/airlock/main.bicep Adds fromEmail parameter and forwards it to the Logic App module
research-spoke/spoke-modules/airlock/logicApp.bicep Accepts fromEmail parameter and passes it to the Logic App workflow
research-spoke/spoke-modules/airlock/content/logicAppWorkflow.json Updates all email actions to include the configurable "From" field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SvenAelterman
SvenAelterman marked this pull request as draft September 17, 2025 15:27
@SvenAelterman
SvenAelterman marked this pull request as ready for review November 14, 2025 21:41
Copilot AI review requested due to automatic review settings November 14, 2025 21:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SvenAelterman
SvenAelterman merged commit 3a4dc91 into main Nov 14, 2025
7 of 8 checks passed
@SvenAelterman
SvenAelterman deleted the 211-allow-regular-emails-sent-by-logic-app-to-be-sent-on-behalf-of branch November 14, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow regular emails sent by Logic App to be sent on behalf of

2 participants