Remove From property on approval email#219
Merged
SvenAelterman merged 2 commits intoDec 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the From property from the Logic App approval email webhook action, as this connector type doesn't require or support custom sender addresses. The approval email functionality uses a specialized Office 365 approval connector that handles the sender address automatically.
- Removed
Fromproperty from theSend_approval_emailaction which uses the/approvalmail/$subscriptionsendpoint - Added "approvalmail" to VS Code spell-check dictionary for the approval connector path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| research-spoke/spoke-modules/airlock/content/logicAppWorkflow.json | Removes the unsupported From property from the approval email webhook action while preserving it in other regular email actions |
| .vscode/settings.json | Adds "approvalmail" to the spell-check dictionary to recognize the approval email connector path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SvenAelterman
deleted the
217-do-not-set-fromemail-property-on-send-approval-email-step-in-logic-app
branch
December 1, 2025 17:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.