Support for Entra ID External ID to sign in to spoke host pools#226
Open
SvenAelterman wants to merge 2 commits into
Open
Support for Entra ID External ID to sign in to spoke host pools#226SvenAelterman wants to merge 2 commits into
SvenAelterman wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the default Windows 11 version for Azure Virtual Desktop session hosts and makes the Active Directory OU path optional during domain join operations. However, there's a disconnect between the PR title which mentions "Support for Entra ID External ID" and the description which only mentions a Windows version update.
Changes:
- Updated default Windows 11 SKU from 23H2 to 25H2 for session hosts
- Made the Active Directory OU path optional using the safe navigation operator
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| shared-modules/virtualDesktop/sessionHosts.bicep | Updated default Windows 11 image SKU from win11-23h2-avd-m365 to win11-25h2-avd-m365 |
| shared-modules/compute/virtualMachine.bicep | Applied optional chaining operator to adOuPath field in domain join extension settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just an update to the default Windows 11 version for spoke session hosts.