project: Add ability to import and convert namespaces into projects by gambtho · Pull Request #314 · Azure/aks-desktop

gambtho · 2026-02-24T19:53:29Z

Summary

Implements the namespace-to-project conversion experience allowing users to import existing AKS managed namespaces as AKS Desktop projects.

For issue:

projects: Turn managed namespace in Projects experience #163

Unified Import Page

Rewrites ImportAKSProjects to discover all managed namespaces (not just pre-labeled ones) via Azure Resource Graph
Adds an "AKS Project?" status column showing whether each namespace already has AKS Desktop labels
When importing namespaces that aren't yet projects, a ConversionDialog confirms label application (headlamp.dev/project-managed-by: aks-desktop) before proceeding
Handles permission errors gracefully with clear messaging

Shared Utilities

Extracts assignRolesToNamespace() from CreateAKSProject into utils/azure/roleAssignment.ts for reuse
Adds applyProjectLabels() and fetchNamespaceData() in utils/kubernetes/namespaceUtils.ts for K8s label operations
Refactors CreateAKSProject.tsx to use the shared role assignment utility (~130 lines removed)

New Components

ConversionDialog — confirmation popup disclosing which labels will be added
useNamespaceDiscovery hook — Resource Graph discovery with isAksProject status, system namespace filtering, already-imported filtering
CreateProjectFromNamespace wizard — 5-step flow for advanced conversion (namespace selection, networking, compute, access, review)

Other

Adds documentation links in README
Registers new routes and create-project options in index.tsx

File Changes

Category	Files
New	`ConversionDialog.tsx`, `ImportAKSProjects/hooks/useNamespaceDiscovery.ts`, `CreateProjectFromNamespace/` (wizard + components + hook), `roleAssignment.ts`, `namespaceUtils.ts`
Modified	`ImportAKSProjects.tsx` (rewrite), `CreateAKSProject.tsx` (refactor), `index.tsx` (registrations), `README.md`
Tests	`namespaceUtils.test.ts` (10 tests), `roleAssignment.test.ts` (9 tests)

Test plan

All CI checks pass (tsc, lint, format, build, tests)
ImportAKSProjects page shows all managed namespaces with "AKS Project?" column
Selecting already-labeled namespaces imports directly without dialog
Selecting unlabeled namespaces shows ConversionDialog with label disclosure
Confirming conversion applies labels and imports successfully
Permission denied errors show clear messaging
CreateAKSProject wizard still works after role assignment refactor
CreateProjectFromNamespace wizard works end-to-end for advanced conversion

Copilot

Pull request overview

This pull request adds a new "AKS project from existing namespace" feature that enables users to convert existing AKS managed namespaces into Headlamp projects. The feature addresses the gap where namespaces created outside AKS Desktop (via Azure CLI or Portal) could not be turned into projects. The implementation follows the codebase's established patterns and successfully extracts shared role assignment logic into reusable utilities.

Changes:

New wizard flow for converting or importing managed namespaces with 5 steps: namespace selection, networking policies, compute quota, access control, and review
Shared utility modules for role assignment (roleAssignment.ts) and namespace label management (namespaceUtils.ts)
Azure Resource Graph-based namespace discovery with platform-specific query quoting for Windows compatibility
Documentation links added to README for AKS Desktop and managed namespaces

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`utils/kubernetes/namespaceUtils.ts`	New utility for fetching namespace data via K8s API and applying project labels
`utils/azure/roleAssignment.ts`	Extracted shared role assignment logic from CreateAKSProject into reusable utility function
`hooks/useNamespaceDiscovery.ts`	New hook that discovers managed namespaces via Azure Resource Graph with categorization
`components/NamespaceSelectionStep.tsx`	Namespace picker UI with radio selection tables for conversion vs import categories
`components/FromNamespaceReviewStep.tsx`	Review step displaying labels, config, and user assignments before conversion
`CreateProjectFromNamespace.tsx`	Main wizard component orchestrating the 5-step conversion/import flow
`index.tsx`	Route and custom create project registration for new namespace conversion feature
`CreateAKSProject.tsx`	Refactored to use shared `assignRolesToNamespace` utility, reducing duplication
`README.md`	Added documentation section with links to AKS Desktop and managed namespaces docs
`docs/implementation-plan-namespace-to-project.md`	Comprehensive implementation plan document (800 lines)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

plugins/aks-desktop/src/components/CreateProjectFromNamespace/hooks/useNamespaceDiscovery.ts

plugins/aks-desktop/src/components/CreateProjectFromNamespace/CreateProjectFromNamespace.tsx

plugins/aks-desktop/src/utils/kubernetes/namespaceUtils.ts

plugins/aks-desktop/src/utils/azure/roleAssignment.ts

plugins/aks-desktop/src/components/CreateProjectFromNamespace/CreateProjectFromNamespace.tsx

Copilot

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

plugins/aks-desktop/vitest.config.mts

plugins/aks-desktop/src/hooks/useNamespaceDiscovery.ts

.../aks-desktop/src/components/CreateProjectFromNamespace/components/NamespaceSelectionStep.tsx

plugins/aks-desktop/src/components/ImportAKSProjects/ImportAKSProjects.tsx

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

plugins/aks-desktop/src/utils/shared/isAksProject.tsx:23

The cancel function is not being called in the error callback. According to the codebase conventions, cancelFn must be awaited and called in both success and error callbacks to prevent resource leaks. Add cancelFn.then(it => it()); inside the error callback.

      () => {
        res(false);
      },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

plugins/aks-desktop/src/utils/shared/isAksProject.tsx

illume

Can you please break this down into some smaller commits?

docs/implementation-plan-namespace-to-project.md

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.tsx

plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx

plugins/aks-desktop/src/hooks/useNamespaceDiscovery.ts

plugins/aks-desktop/src/components/ImportAKSProjects/ImportAKSProjects.tsx

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

plugins/aks-desktop/src/components/ImportAKSProjects/ImportAKSProjects.tsx

plugins/aks-desktop/src/components/ImportAKSProjects/components/ConversionDialog.test.tsx

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx

plugins/aks-desktop/src/components/ImportAKSProjects/ImportAKSProjects.tsx

plugins/aks-desktop/src/utils/kubernetes/namespaceUtils.ts

Copilot

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

illume · 2026-02-27T10:49:41Z

@gambtho can you please add the issue into the PR description?

Found it:

projects: Turn managed namespace in Projects experience #163

Move hardcoded project label strings into utils/constants/projectLabels.ts and update all consumers (CreateAKSProject, DeleteAKSProject, InfoTab, Metrics, Scaling, isAksProject). Also fix useClustersConf import path.

Move the inline role assignment loop from CreateAKSProject into a reusable assignRolesToNamespace() function in utils/azure/roleAssignment.ts. This will also be used by the namespace import flow.

…ooks Add helper utilities for the namespace import feature: - namespaceUtils: fetch namespace data and apply project labels via K8s API - clusterSettings: read/write per-cluster localStorage settings - useRegisteredClusters: hook returning registered cluster names - useNamespaceDiscovery: discovers AKS managed namespaces (via Azure Resource Graph) and regular K8s namespaces, categorizing them as needing conversion or import Includes vitest config and tests for all new modules.

Rewrite the import page to use the new useNamespaceDiscovery hook, supporting both managed namespace import and regular namespace conversion to projects. Add ConversionDialog for converting unlabeled namespaces. Update plugin registration text and add documentation links to README.

Copilot AI review requested due to automatic review settings February 24, 2026 19:53

Copilot started reviewing on behalf of gambtho February 24, 2026 19:54 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

gambtho changed the title ~~project: Add ability to create projects from existing managed namespaces~~ project: Add ability to import and convert namespaces into projects Feb 24, 2026

gambtho force-pushed the thgamble/nstoproj branch from 35b38a6 to bf3548f Compare February 25, 2026 00:17

Copilot AI review requested due to automatic review settings February 25, 2026 00:26

gambtho force-pushed the thgamble/nstoproj branch from bf3548f to ea277f2 Compare February 25, 2026 00:26

Copilot started reviewing on behalf of gambtho February 25, 2026 00:26 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

gambtho force-pushed the thgamble/nstoproj branch from ea277f2 to 675a74f Compare February 25, 2026 02:07

Copilot AI review requested due to automatic review settings February 25, 2026 04:51

gambtho force-pushed the thgamble/nstoproj branch from 675a74f to 5f53f75 Compare February 25, 2026 04:51

Copilot started reviewing on behalf of gambtho February 25, 2026 04:52 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

plugins/aks-desktop/src/utils/shared/isAksProject.tsx Outdated Show resolved Hide resolved

illume requested changes Feb 25, 2026

View reviewed changes

docs/implementation-plan-namespace-to-project.md Outdated Show resolved Hide resolved

gambtho force-pushed the thgamble/nstoproj branch from 5f53f75 to ec3a329 Compare February 25, 2026 14:29

Copilot AI review requested due to automatic review settings February 25, 2026 14:36

gambtho force-pushed the thgamble/nstoproj branch from ec3a329 to d90b62d Compare February 25, 2026 14:36

Copilot started reviewing on behalf of gambtho February 25, 2026 14:37 View session

gambtho force-pushed the thgamble/nstoproj branch from d90b62d to ce30d98 Compare February 25, 2026 14:39

Copilot AI reviewed Feb 25, 2026

View reviewed changes

gambtho requested a review from illume February 25, 2026 14:49

gambtho force-pushed the thgamble/nstoproj branch from ce30d98 to 9ac09a4 Compare February 25, 2026 14:55

Copilot AI review requested due to automatic review settings February 25, 2026 15:03

gambtho force-pushed the thgamble/nstoproj branch from 9ac09a4 to 175a3c2 Compare February 25, 2026 15:03

Copilot AI reviewed Feb 25, 2026

View reviewed changes

plugins/aks-desktop/src/components/ImportAKSProjects/ImportAKSProjects.tsx Outdated Show resolved Hide resolved

plugins/aks-desktop/src/components/ImportAKSProjects/components/ConversionDialog.test.tsx Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings February 25, 2026 23:01

gambtho force-pushed the thgamble/nstoproj branch from 0f43e69 to b257e67 Compare February 25, 2026 23:01

Copilot started reviewing on behalf of gambtho February 25, 2026 23:02 View session

gambtho force-pushed the thgamble/nstoproj branch from b257e67 to 0411f2c Compare February 25, 2026 23:05

Copilot AI reviewed Feb 25, 2026

View reviewed changes

gambtho force-pushed the thgamble/nstoproj branch from 0411f2c to 7a59a6c Compare February 26, 2026 02:24

Copilot AI review requested due to automatic review settings February 26, 2026 15:11

gambtho force-pushed the thgamble/nstoproj branch from 7a59a6c to b9d61ef Compare February 26, 2026 15:11

Copilot started reviewing on behalf of gambtho February 26, 2026 15:12 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

illume added p3 low priority enhancement New feature or request labels Feb 27, 2026

gambtho added 4 commits February 27, 2026 13:15

projectLabels: Extract project label constants into shared module

009c5d6

Move hardcoded project label strings into utils/constants/projectLabels.ts and update all consumers (CreateAKSProject, DeleteAKSProject, InfoTab, Metrics, Scaling, isAksProject). Also fix useClustersConf import path.

roleAssignment: Extract role assignment logic into shared utility

b9cb8f9

Move the inline role assignment loop from CreateAKSProject into a reusable assignRolesToNamespace() function in utils/azure/roleAssignment.ts. This will also be used by the namespace import flow.

gambtho force-pushed the thgamble/nstoproj branch from b9d61ef to 7ec2064 Compare February 27, 2026 18:15

Conversation

gambtho commented Feb 24, 2026 • edited by illume Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Unified Import Page

Shared Utilities

New Components

Other

File Changes

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

illume commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gambtho commented Feb 24, 2026 •

edited by illume

Loading

illume commented Feb 27, 2026 •

edited

Loading