plugins/aks-desktop: CreateAKSProject: Make errors more accessible#345
plugins/aks-desktop: CreateAKSProject: Make errors more accessible#345illume wants to merge 1 commit intoAzure:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Improves keyboard accessibility in the AKS Desktop “Create AKS Project” flow by making scrollable content regions (assignees list + error details) focusable and giving them a visible focus outline, with ARIA labeling for screen readers.
Changes:
- Make the “Access control assignees” list container keyboard-focusable and scrollable, with a focus outline and ARIA region label.
- Make the error details panel focusable for keyboard scrolling, with a focus outline and ARIA region label.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| plugins/aks-desktop/src/components/CreateAKSProject/components/ReviewStep.tsx | Adds focusability, region semantics, and focus outline to the assignees list container. |
| plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx | Adds focusability, region semantics, and focus outline to the scrollable error details area. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/CreateAKSProject/components/ReviewStep.tsx
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/CreateAKSProject/components/ReviewStep.tsx
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx
Show resolved
Hide resolved
83e5ef5 to
b40297b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx
Show resolved
Hide resolved
b40297b to
27b79d1
Compare
- Have a focus outline. - Make errors keyboard scrollable. - Also add an aria title.
27b79d1 to
d7926ff
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Box | ||
| tabIndex={0} | ||
| role="region" | ||
| aria-label={t('Error details')} | ||
| sx={{ | ||
| flex: 1, | ||
| overflowY: 'auto', | ||
| mb: 2, | ||
| minHeight: '100px', | ||
| maxHeight: '400px', | ||
| '&:focus': { | ||
| outline: '2px solid', | ||
| outlineColor: theme => theme.palette.error.main, | ||
| outlineOffset: '2px', | ||
| }, | ||
| }} |
There was a problem hiding this comment.
aria-label uses t('Error details'), but there is no corresponding i18n key in plugins/aks-desktop/locales/*/translation.json (search shows no matches). This will fall back to the raw key string and won’t be localized; please add the translation key (and required plural/locale entries as needed) or reuse an existing translation key that already exists.
Keyboard-only users couldn't Tab into scrollable regions (project creation failure panel, access control assignees list in Review step), making full error content unreachable without a mouse.
Fixes #300
Description
Adds
tabIndex={0},role="region",aria-label, and a visible:focusoutline to the two scrollableBoxcontainers that were previously keyboard-inaccessible. Once focused, users can scroll with Arrow keys, Page Up/Down, and Home/End.Type of Change
Related Issues
Changes Made
CreateAKSProject.tsx:tabIndex={0}+role="region"+aria-label+ focus outline on the scrollable error details panelReviewStep.tsx: same treatment on the scrollable access control assignees listTesting
Test Cases
Screenshots/Videos
If applicable, add screenshots or videos to demonstrate the changes.
Checklist
Breaking Changes
N/A
Performance Impact
Documentation Updates
Reviewer Notes
Both scrollable containers now receive the same accessibility treatment for consistency. Focus outline color matches the context:
error.mainfor the failure panel,primary.mainfor the access control list.