Updates StatementExecutionApiClient Execute, Get & GetResultChunk to use source generation#291
Open
mellis-ao wants to merge 11 commits intoAzure:masterfrom
Open
Updates StatementExecutionApiClient Execute, Get & GetResultChunk to use source generation#291mellis-ao wants to merge 11 commits intoAzure:masterfrom
mellis-ao wants to merge 11 commits intoAzure:masterfrom
Conversation
…se source generation.
…16) when the content is JSON (UTF-8).
Signed-off-by: mellis-ao <157610114+mellis-ao@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this is to resolve #290 but also to start the ball rolling on adding
RequiresUnreferencedCodeattributes & improve awareness of other contributors whether the code is trim safe.Directory.Build.propsto centralise framework targets<EnableTrimAnalyzer>true</EnableTrimAnalyzer>to trigger warnings in the code to prompt use ofRequiresUnreferencedCodeor to use source generated alternatives.[RequiresUnreferencedCode]usage onApiClientand other areas related to the SQL Api.JsonContentinstead ofStringContentto avoid the overhead of UTF-16 on strings.Testing:
Unit tests pass:
Also published a copy of this package to our private Azure Artifacts feed with the fixes and tested in our scenarios. We were able to add
<JsonSerializerIsReflectionEnabledByDefault>false</JsonSerializerIsReflectionEnabledByDefault>to our project and not hit any errors (as well was getting results as expected).