-
Notifications
You must be signed in to change notification settings - Fork 44
* Use open-rewrite to migrate from JDK8 to JDK11 #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Update release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a breaking change by migrating the minimum required Java version from Java 8 to Java 11. The migration leverages OpenRewrite to systematically update the codebase with Java 11 best practices, including replacing deprecated APIs and modernizing Maven compiler plugin configurations.
- Updated minimum Java version from 1.8 to 11 across all Maven modules
- Replaced
Paths.get()withPath.of()in both production and test code (10 occurrences across 7 files) - Modernized Maven compiler plugin configuration by replacing
<source>/<target>with<release>tag
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated project version to 8.0.0, changed java.version from 1.8 to 11, and added OpenRewrite Maven plugin for migration |
| CHANGELOG.md | Added release notes for version 8.0.0 documenting the breaking change for Java 11 requirement |
| quickstart/pom.xml | Updated java.version from 1.8 to 11 and replaced source/target with release in maven-compiler-plugin |
| samples/pom.xml | Replaced source/target with release in maven-compiler-plugin configuration |
| ingest/pom.xml | Replaced source/target with release in maven-compiler-plugin configuration |
| data/pom.xml | Replaced source/target with release in maven-compiler-plugin configuration |
| ingest/src/test/java/com/microsoft/azure/kusto/ingest/StreamingIngestClientTest.java | Replaced Paths import with Path and updated Paths.get() to Path.of() |
| ingest/src/test/java/com/microsoft/azure/kusto/ingest/QueuedIngestClientTest.java | Replaced Paths import with Path and updated Paths.get() to Path.of() (3 occurrences) |
| ingest/src/test/java/com/microsoft/azure/kusto/ingest/E2ETest.java | Replaced Paths import with Path and updated Paths.get() to Path.of() (2 occurrences) |
| ingest/src/test/java/com/microsoft/azure/kusto/ingest/AzureStorageClientTest.java | Replaced Paths import with Path and updated Paths.get() to Path.of() (7 occurrences) |
| data/src/test/java/com/microsoft/azure/kusto/data/auth/AadAuthenticationHelperTest.java | Replaced Paths import with Path and updated Paths.get() to Path.of() (4 occurrences) |
| data/src/test/java/com/microsoft/azure/kusto/data/UtilitiesTest.java | Replaced Paths import with Path and updated Paths.get() to Path.of() |
| data/src/test/java/com/microsoft/azure/kusto/data/ConnectionStringBuilderTest.java | Replaced Paths import with Path and updated Paths.get() to Path.of() (2 occurrences) |
| data/src/main/java/com/microsoft/azure/kusto/data/UriUtils.java | Replaced Paths import with Path and updated Paths.get() to Path.of() in production code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request introduces a breaking change by updating the minimum required Java version to Java 11 (previously Java 8) across the project. In addition, it modernizes the codebase by replacing deprecated usages of
Paths.getwithPath.ofand updates Maven compiler plugin configurations to use the<release>flag. These changes ensure better compatibility with newer Java features and enhance maintainability.Breaking Change:
The minimum supported Java version is now Java 11. Users must upgrade from Java 8 to Java 11 or later to use this SDK.
Build and Dependency Updates:
Updated all Maven
pom.xmlfiles to setjava.versionto 11 and replaced<source>/<target>with<release>in themaven-compiler-pluginconfiguration.Replaced all usages of
Paths.getwithPath.ofin both source and test files to align with Java 11 best practices.This description is auto-generated