Users/ramacg/refactor managed uploader#455
Merged
ag-ramachandran merged 9 commits intofeature/IngestV2from Jan 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the ManagedUploader by simplifying the selectContainers method interface and enhancing the configuration cache to support server-specified refresh intervals.
Key Changes:
- Removed
configurationCacheparameter fromselectContainersmethod, accessing it as a class property instead - Changed
configurationCachevisibility from private to public inContainerUploaderBase - Added logic to use server-specified refresh intervals from configuration responses
- Added comprehensive tests for container selection with different upload methods
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ingest-v2/src/test/resources/config-response.json | New test fixture providing sample configuration with both storage and lake containers |
| ingest-v2/src/test/kotlin/com/microsoft/azure/kusto/ingest/v2/uploader/ManagedUploaderTest.kt | New parameterized test validating container selection logic for DEFAULT, STORAGE, and LAKE upload methods |
| ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/uploader/ManagedUploader.kt | Removed configurationCache parameter from selectContainers method signature |
| ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/uploader/ContainerUploaderBase.kt | Made configurationCache property public and updated selectContainers signature and documentation |
| ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/common/ConfigurationCache.kt | Enhanced to calculate effective refresh interval using minimum of default and server-specified intervals |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/common/ConfigurationCache.kt
Outdated
Show resolved
Hide resolved
ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/uploader/ContainerUploaderBase.kt
Outdated
Show resolved
Hide resolved
ingest-v2/src/test/kotlin/com/microsoft/azure/kusto/ingest/v2/uploader/ManagedUploaderTest.kt
Show resolved
Hide resolved
ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/uploader/ContainerUploaderBase.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
128
to
182
| LocalTime.parse(configRefreshInterval).toSecondOfDay() * | ||
| 1000L, |
There was a problem hiding this comment.
The refresh interval parsing uses LocalTime.parse() which expects a time format (HH:mm:ss), but the actual format in the config is a TimeSpan/Duration string ("01:00:00"). While "01:00:00" may parse as LocalTime, this is semantically incorrect - you're parsing a duration as a time-of-day. Consider using Duration.parse() with the ISO-8601 duration format (e.g., "PT1H") or implement proper TimeSpan parsing that handles the format correctly.
ingest-v2/src/test/kotlin/com/microsoft/azure/kusto/ingest/v2/uploader/ManagedUploaderTest.kt
Outdated
Show resolved
Hide resolved
ag-ramachandran
force-pushed
the
users/ramacg/RefactorManagedUploader
branch
from
a51c91a to
5000240
Compare
ag-ramachandran
had a problem deploying
to
build
GitHub Actions
Failure
ag-ramachandran
had a problem deploying
to
build
GitHub Actions
Failure
…uploader/ContainerUploaderBase.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…uploader/ContainerUploaderBase.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ag-ramachandran
force-pushed
the
users/ramacg/RefactorManagedUploader
branch
from
4617c4d to
4f991dc
Compare
ag-ramachandran
had a problem deploying
to
build
GitHub Actions
Failure
…uploader/ManagedUploaderTest.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add tests for duration
ag-ramachandran
had a problem deploying
to
build
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.