Skip to content

Fix: Changes for publishing the package#117

Merged
asaharn merged 13 commits intomasterfrom
asaharn/feat/releasePipeChange
Apr 15, 2026
Merged

Fix: Changes for publishing the package#117
asaharn merged 13 commits intomasterfrom
asaharn/feat/releasePipeChange

Conversation

@asaharn
Copy link
Copy Markdown
Member

@asaharn asaharn commented Apr 14, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates packaging/build/release configuration to support publishing a renamed v2 package, including a marker data handling fix and new release automation.

Changes:

  • Fix marker bounds logic to handle empty/changed curve data structures without crashing.
  • Update Rollup TypeScript plugin and adjust build exclusion patterns for packaging.
  • Add a tag-based GitHub Release + npm publish workflow and introduce a CHANGELOG.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/UXClient/Components/Marker/Marker.ts Adjusts how marker data points are accessed/filtered to prevent crashes when data is missing.
rollup.config.mjs Switches to @rollup/plugin-typescript and tweaks TS plugin config/exclusions.
package.json Renames the package and changes versioning/deps to support publishing.
CHANGELOG.md Adds changelog entries describing v2 release changes and fixes.
.github/workflows/release.yml Adds a tag-triggered release workflow that publishes GitHub Releases and npm packages.
.github/workflows/build.yaml Updates CI action versions and removes npm publish from the build workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/UXClient/Components/Marker/Marker.ts
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
id: changelog
run: |
version="${GITHUB_REF#refs/tags/v}"
changelog=$(awk "/^## \[${version}\]/{found=1; next} /^## \[/{if(found) exit} found{print}" CHANGELOG.md)
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${version} is interpolated into an awk regex without escaping, so dots in versions (e.g. 2.0.0) will be treated as 'any character' and may match unintended headings. Use a non-regex match (e.g., compare strings) or escape regex metacharacters in the version before building the pattern.

Suggested change
changelog=$(awk "/^## \[${version}\]/{found=1; next} /^## \[/{if(found) exit} found{print}" CHANGELOG.md)
changelog=$(awk -v version="$version" 'index($0, "## [") == 1 { if ($0 == "## [" version "]") { found=1; next } if (found) exit } found { print }' CHANGELOG.md)

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/build.yaml
Comment thread package.json Outdated
Comment thread CHANGELOG.md Outdated
@asaharn asaharn merged commit 3fa8867 into master Apr 15, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants