Fix: Changes for publishing the package#117
Conversation
fix: Corrected no data addMarker fix
…into asaharn/feat/releasePipeChange
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates packaging/build/release configuration to support publishing a renamed v2 package, including a marker data handling fix and new release automation.
Changes:
- Fix marker bounds logic to handle empty/changed curve data structures without crashing.
- Update Rollup TypeScript plugin and adjust build exclusion patterns for packaging.
- Add a tag-based GitHub Release + npm publish workflow and introduce a CHANGELOG.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/UXClient/Components/Marker/Marker.ts | Adjusts how marker data points are accessed/filtered to prevent crashes when data is missing. |
| rollup.config.mjs | Switches to @rollup/plugin-typescript and tweaks TS plugin config/exclusions. |
| package.json | Renames the package and changes versioning/deps to support publishing. |
| CHANGELOG.md | Adds changelog entries describing v2 release changes and fixes. |
| .github/workflows/release.yml | Adds a tag-triggered release workflow that publishes GitHub Releases and npm packages. |
| .github/workflows/build.yaml | Updates CI action versions and removes npm publish from the build workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| id: changelog | ||
| run: | | ||
| version="${GITHUB_REF#refs/tags/v}" | ||
| changelog=$(awk "/^## \[${version}\]/{found=1; next} /^## \[/{if(found) exit} found{print}" CHANGELOG.md) |
There was a problem hiding this comment.
${version} is interpolated into an awk regex without escaping, so dots in versions (e.g. 2.0.0) will be treated as 'any character' and may match unintended headings. Use a non-regex match (e.g., compare strings) or escape regex metacharacters in the version before building the pattern.
| changelog=$(awk "/^## \[${version}\]/{found=1; next} /^## \[/{if(found) exit} found{print}" CHANGELOG.md) | |
| changelog=$(awk -v version="$version" 'index($0, "## [") == 1 { if ($0 == "## [" version "]") { found=1; next } if (found) exit } found { print }' CHANGELOG.md) |
No description provided.