Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes test failures that occur when Azure service properties (like accountName, namespace, or endpoint) are configured in application.yaml alongside Docker Testcontainers or Docker Compose connection details beans. The fix ensures that connection strings provided by ConnectionDetails beans are the single source of truth by nulling out properties that would otherwise be used to derive conflicting endpoint URLs or fully qualified domain names.
Changes:
- Nulls properties that derive connection information (accountName, namespace, endpoint) when ConnectionDetails beans provide connection strings
- Ensures consistency across Storage Blob, Storage Queue, Service Bus, and Event Hubs configurations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ConfigurationWithConnectionDetailsBean.java (Storage Queue) |
Sets accountName to null after setting connection string and endpoint from connection details |
ConfigurationWithConnectionDetailsBean.java (Storage Blob) |
Sets accountName and endpoint to null after setting connection string from connection details |
ConfigurationWithConnectionDetailsBean.java (Service Bus) |
Sets namespace to null after setting connection string from connection details |
ConfigurationWithConnectionDetailsBean.java (Event Hubs) |
Sets namespace to null after setting connection string from connection details |
Member
Author
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Netyyyy
approved these changes
Feb 26, 2026
Netyyyy
pushed a commit
to Netyyyy/azure-sdk-for-java
that referenced
this pull request
Feb 28, 2026
(cherry picked from commit 8f82f8c)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to related PRs:
Before current PR, the unit test will fail when some property configured in application.yaml. Here is the screenshot:
After current PR, test passed. Here is the screenshot: