Skip to content

Fix error about test by docker#48105

Merged
rujche merged 1 commit intomainfrom
rujche/main/fix-error-about-test-by-docker
Feb 26, 2026
Merged

Fix error about test by docker#48105
rujche merged 1 commit intomainfrom
rujche/main/fix-error-about-test-by-docker

Conversation

@rujche
Copy link
Member

@rujche rujche commented Feb 25, 2026

Copilot AI review requested due to automatic review settings February 25, 2026 05:37
@rujche rujche requested review from a team, Netyyyy, moarychan and saragluna as code owners February 25, 2026 05:37
@rujche rujche self-assigned this Feb 25, 2026
@rujche rujche added azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. azure-spring-eventhubs Spring event hubs related issues. azure-spring-storage Spring storage releated issues. azure-spring-cosmos Spring cosmos related issues. labels Feb 25, 2026
@rujche rujche moved this to In Progress in Spring Cloud Azure Feb 25, 2026
@rujche rujche added this to the 2026-03 milestone Feb 25, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes test failures that occur when Azure service properties (like accountName, namespace, or endpoint) are configured in application.yaml alongside Docker Testcontainers or Docker Compose connection details beans. The fix ensures that connection strings provided by ConnectionDetails beans are the single source of truth by nulling out properties that would otherwise be used to derive conflicting endpoint URLs or fully qualified domain names.

Changes:

  • Nulls properties that derive connection information (accountName, namespace, endpoint) when ConnectionDetails beans provide connection strings
  • Ensures consistency across Storage Blob, Storage Queue, Service Bus, and Event Hubs configurations

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
ConfigurationWithConnectionDetailsBean.java (Storage Queue) Sets accountName to null after setting connection string and endpoint from connection details
ConfigurationWithConnectionDetailsBean.java (Storage Blob) Sets accountName and endpoint to null after setting connection string from connection details
ConfigurationWithConnectionDetailsBean.java (Service Bus) Sets namespace to null after setting connection string from connection details
ConfigurationWithConnectionDetailsBean.java (Event Hubs) Sets namespace to null after setting connection string from connection details

@rujche
Copy link
Member Author

rujche commented Feb 25, 2026

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rujche rujche merged commit 8f82f8c into main Feb 26, 2026
91 checks passed
@rujche rujche deleted the rujche/main/fix-error-about-test-by-docker branch February 26, 2026 09:21
@github-project-automation github-project-automation bot moved this from In Progress to Done in Spring Cloud Azure Feb 26, 2026
Netyyyy pushed a commit to Netyyyy/azure-sdk-for-java that referenced this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues azure-spring-cosmos Spring cosmos related issues. azure-spring-eventhubs Spring event hubs related issues. azure-spring-servicebus Spring service bus related issues. azure-spring-storage Spring storage releated issues.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants