-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Security improvements in Spring Cloud Azure AAD #49033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rujche
merged 31 commits into
main
from
rujche/main/fix-issue-in-AadJwtIssuerValidator.trustedIssuerRepoValidIssuer
May 7, 2026
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
a8bf37e
Fix AAD issuer and audience validation defaults
rujche a88077e
Update change log
rujche 3d2b4b4
Address review comments: fix import order, centralize isMultiTenantsA…
Copilot fc1af23
Revert isMultiTenantsApplication to private: not intended as public API
Copilot 5261f67
Revert static modifier from isMultiTenantsApplication in AadAuthentic…
Copilot 50ff6de
Fix grammar and spacing in UserPrincipalManager audience-mismatch err…
Copilot 8dbba20
Fix critical security vulnerability in AAD Resource Server tenant val…
rujche 2a273b5
Add explicit tenant ID (tid) claim validation
rujche 73c3ca4
Simplify tenant ID validation logic and unify error messages
rujche 01e3e23
Update CHANGELOG for AAD resource server security hardening
rujche 22ad1b9
Fix test failures by adding tenant-id configuration
rujche 7c3c599
Fix CHANGELOG wording and redundant tests per review feedback
Copilot a338c24
Update changelog
rujche 940ab78
Potential fix for pull request finding
rujche aae84ed
Potential fix for pull request finding
rujche 5070bfe
Update CHANGELOG to document AadAuthenticationFilter audience validation
rujche 8e15962
Update comment
rujche 81eb2f4
Delete comment
rujche 0d4a4fa
Delete useless empty lines
rujche 93f7bbb
Potential fix for pull request finding
rujche cbaa20b
Potential fix for pull request finding
rujche 583fe2c
Potential fix for pull request finding
rujche 72e7f88
Fix test assertions to match actual validateTenantId error message
Copilot ec7587c
Trim tenant-id before validation and use in validators to prevent whi…
Copilot 1174bab
Add test for whitespace-padded reserved tenant-id rejection after tri…
Copilot 93f18a6
Trim tenant-id in jwtDecoder() before building AadAuthorizationServer…
Copilot 3c3b72f
Extract getTrimmedTenantId helper to eliminate duplicate trim logic
Copilot 975e867
Remove unused aadAuthenticationProperties field and stubs from AadJwt…
Copilot 50a21f8
Potential fix for pull request finding
rujche b007f7c
Merge branch 'main' into rujche/main/fix-issue-in-AadJwtIssuerValidat…
rujche 6822bf7
Normalize tenant ID to lowercase for case-insensitive tid/iss validat…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.