[identity-cache-persistence] Upgrading MSAL extensions#19356
Merged
sadasant merged 3 commits intoAzure:mainfrom Dec 15, 2021
Merged
[identity-cache-persistence] Upgrading MSAL extensions#19356sadasant merged 3 commits intoAzure:mainfrom
sadasant merged 3 commits intoAzure:mainfrom
Conversation
ghost
added
the
sadasant
requested review from
deyaaeldeen,
mikeharder,
praveenkuttappan,
schaabs and
witemple-msft
as code owners
witemple-msft
approved these changes
Dec 15, 2021
ramya-rao-a
approved these changes
Dec 15, 2021
sadasant
force-pushed
the
identity/fix19303
branch
from
709fcfd to
9694ea7
Compare
ramya-rao-a
reviewed
Dec 15, 2021
| '@azure/msal-common': 4.5.1 | ||
| bindings: 1.5.0 | ||
| '@azure/msal-common': 5.2.0 | ||
| bindings: github.com/samuelkubai/node-bindings/3a5a099ed0178b65079ce18e11fccc7130e0af1e |
Contributor
There was a problem hiding this comment.
This is odd. Can we check with the msal team why we are using personal node bindings here?
Contributor
Author
There was a problem hiding this comment.
This is because this PR hasn’t been merged: TooTallNate/node-bindings#74
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19303