Re-emit from TypeSpec to pick up fix for "type" discriminator in WebSearchApproximateLocation#45276
Open
Re-emit from TypeSpec to pick up fix for "type" discriminator in WebSearchApproximateLocation#45276
Conversation
dargilco
requested review from
glharper,
howieleung,
kingernupur,
nick863,
trangevi and
trrwilson
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-emits the azure-ai-projects generated Python models from TypeSpec to incorporate an upstream fix for the "type" discriminator on WebSearchApproximateLocation.
Changes:
- Updates
WebSearchApproximateLocation.typeto be a requiredLiteral["approximate"]and ensures it is set during initialization. - Removes trailing whitespace-only lines in several web search-related sample docstrings.
Reviewed changes
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-projects/samples/agents/tools/sample_agent_web_search_with_custom_search.py | Trims whitespace-only docstring line. |
| sdk/ai/azure-ai-projects/samples/agents/tools/sample_agent_web_search_preview.py | Trims whitespace-only docstring line. |
| sdk/ai/azure-ai-projects/samples/agents/tools/sample_agent_bing_grounding.py | Trims whitespace-only docstring line. |
| sdk/ai/azure-ai-projects/samples/agents/tools/sample_agent_bing_custom_search.py | Trims whitespace-only docstring line. |
| sdk/ai/azure-ai-projects/azure/ai/projects/models/_models.py | Regenerated model: makes WebSearchApproximateLocation.type a required literal discriminator and assigns "approximate" in __init__. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit from TypeSpec PR: Azure/azure-rest-api-specs#40594