improve inline type property decorator completion logic and add tests#19174
Open
polatengin wants to merge 1 commit intomainfrom
Open
improve inline type property decorator completion logic and add tests#19174polatengin wants to merge 1 commit intomainfrom
polatengin wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Test this change out locally with the following install scripts (Action run 23091409924) VSCode
Azure CLI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16942
Description
Fix decorator completions for properties inside inline object types (for example,
param foo { @| name: string }) to suggest decorators based on the property's type rather than the enclosing declaration's type.Example Usage
Before this fix, typing
@on an inline object type property would show incomplete completions:With this PR, completions align with the property's type;
Microsoft Reviewers: Open in CodeFlow