This repository was archived by the owner on Jul 18, 2024. It is now read-only.
Fix 144, add support for Managed Disk SAS tokens#145
Open
kf6kjg wants to merge 3 commits intoAzure:developfrom
Open
Fix 144, add support for Managed Disk SAS tokens#145kf6kjg wants to merge 3 commits intoAzure:developfrom
kf6kjg wants to merge 3 commits intoAzure:developfrom
Conversation
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Author
|
Hmm, CI failure looks to be caused by the CI using Fixing that bit of outdated config to get CI working.. |
Author
|
Looks like the CI is still broken, this time because of a codecov usage problem: I'll leave the fixing of that one up to the repo maintainers, I've used as much time on this today as I can afford. I recommend that the maintainers pin the versions of the tools they are using in their CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
masterif it includes no features (open againstdevelopotherwise)Description
Re-works the domain parsing for
modeandepto work with managed disk URLs and all existing URLs as well.Fixes #144