Skip to content

[Calling][Refactor] More Call Options, End Call Confirm, Audio options ported to SwiftUI#877

Open
ahammer wants to merge 42 commits intodevelopfrom
feature/update_exit_confirmation_audio_and_more_options
Open

[Calling][Refactor] More Call Options, End Call Confirm, Audio options ported to SwiftUI#877
ahammer wants to merge 42 commits intodevelopfrom
feature/update_exit_confirmation_audio_and_more_options

Conversation

@ahammer
Copy link
Copy Markdown
Member

@ahammer ahammer commented Jun 3, 2024

Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Pull request checklist

This PR has considered:

  • Color Theming
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • View Data Injection
  • Demo App UI/UX update

How to Test

  • Open...
  • Click on...

What to Check

Before After
Screenshot or description before this change Screenshot or description with this change

Other Information

@ahammer ahammer changed the base branch from main to develop June 3, 2024 19:40
@ahammer ahammer marked this pull request as ready for review June 11, 2024 08:05
@ahammer ahammer changed the title Feature/update exit confirmation audio and more options [Calling][Refactor] More Call Options, End Call Confirm, Audio options ported to SwiftUI Jun 17, 2024
@ShaunaSong
Copy link
Copy Markdown
Member

Audio Drawer cannot open properly on setup screen, please double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants