Skip to content

Fix helm workflow #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidgamero merged 11 commits into from
Jan 29, 2025
Merged

Fix helm workflow #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
238555f
fix for namespace
bosesuneha Aug 13, 2024
598b863
Merge branch 'Azure:main' into main
bosesuneha Aug 13, 2024
9a26544
Merge branch 'Azure:main' into main
bosesuneha Aug 13, 2024
9b577b3
Merge branch 'Azure:main' into main
bosesuneha Aug 15, 2024
d4dff8c
Merge branch 'Azure:main' into main
bosesuneha Aug 20, 2024
03dc021
Merge branch 'Azure:main' into main
bosesuneha Aug 23, 2024
aaeb0b0
Merge branch 'Azure:main' into main
bosesuneha Oct 18, 2024
4c90cc0
Merge branch 'Azure:main' into main
bosesuneha Nov 21, 2024
29b7314
Merge branch 'Azure:main' into main
bosesuneha Jan 27, 2025
d80514a
remove parentheses
bosesuneha Jan 29, 2025
1f8654b
Merge branch 'main' into fix-helm-wait
bosesuneha Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/fixtures/workflows/github/helm/.github/workflows/azure-kubernetes-service-helm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,6 @@ jobs:
- name: Deploy application on public cluster
if: ${{ steps.isPrivate.outputs.PRIVATE_CLUSTER != 'true' }}
env:
WAIT_FLAG: ${{ (env.CLUSTER_RESOURCE_TYPE != 'Microsoft.ContainerService/fleets') && '--wait') || '' }} # don't wait for fleet hubs
WAIT_FLAG: ${{ (env.CLUSTER_RESOURCE_TYPE != 'Microsoft.ContainerService/fleets') && '--wait' || '' }} # don't wait for fleet hubs
run: |
helm upgrade ${{ env.WAIT_FLAG }} -i -f ${{ env.CHART_OVERRIDE_PATH }} --set ${{ env.CHART_OVERRIDES }} --set image.tag=${{ github.sha }} automated-deployment ${{ env.CHART_PATH }} --namespace ${{ env.NAMESPACE }}
2 changes: 1 addition & 1 deletion template/workflows/helm/.github/workflows/azure-kubernetes-service-helm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:
- name: Deploy application on public cluster
if: ${{ steps.isPrivate.outputs.PRIVATE_CLUSTER != 'true' }}
env:
WAIT_FLAG: ${{ (env.CLUSTER_RESOURCE_TYPE != 'Microsoft.ContainerService/fleets') && '--wait') || '' }} # don't wait for fleet hubs
WAIT_FLAG: ${{ (env.CLUSTER_RESOURCE_TYPE != 'Microsoft.ContainerService/fleets') && '--wait' || '' }} # don't wait for fleet hubs
run: |
helm upgrade ${{ env.WAIT_FLAG }} -i -f ${{ env.CHART_OVERRIDE_PATH }} --set ${{ env.CHART_OVERRIDES }} --set image.tag=${{ github.sha }} automated-deployment ${{ env.CHART_PATH }} --namespace ${{ env.NAMESPACE }}
`}}
Loading