Merged
Conversation
Tatsinnit
approved these changes
Jan 30, 2025
Member
Tatsinnit
left a comment
There was a problem hiding this comment.
❤️ Thank you for kind ping and this PR, a quick note, you can always rebase, but given repo as squash compulsory all this will go away in the end.
- Also do we have testing cadence for capturing these kind of breaks currently in our testing ability within this repo? (if you know) like manual test or any other way then we should introduce that as sanity check.
Thank you so much as always.
Member
Author
|
@Tatsinnit Yes, I will rebase going forward. Currently, we don't have any tests for validating the workflows, but we should consider adding some e2e tests to avoid multiple iterations of releases. |
Vidya2606
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release v0.17.3 contains syntax fix for helm deployment workflow template.
PR 482
Fixes # (issue)
Feature # (details)
Type of change
How Has This Been Tested?
Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).
Checklist: