Skip to content

Release v0.17.3#484

Merged
bosesuneha merged 12 commits intoAzure:mainfrom
bosesuneha:release-v0.17.3
Jan 30, 2025
Merged

Release v0.17.3#484
bosesuneha merged 12 commits intoAzure:mainfrom
bosesuneha:release-v0.17.3

Conversation

@bosesuneha
Copy link
Member

Description

Release v0.17.3 contains syntax fix for helm deployment workflow template.
PR 482

Fixes # (issue)
Feature # (details)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you for kind ping and this PR, a quick note, you can always rebase, but given repo as squash compulsory all this will go away in the end.

  • Also do we have testing cadence for capturing these kind of breaks currently in our testing ability within this repo? (if you know) like manual test or any other way then we should introduce that as sanity check.

Thank you so much as always.

Screenshot 2025-01-31 at 9 38 16 AM

@Tatsinnit Tatsinnit requested a review from davidgamero January 30, 2025 20:40
@bosesuneha
Copy link
Member Author

@Tatsinnit Yes, I will rebase going forward. Currently, we don't have any tests for validating the workflows, but we should consider adding some e2e tests to avoid multiple iterations of releases.

Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bosesuneha bosesuneha enabled auto-merge (squash) January 30, 2025 21:17
@bosesuneha bosesuneha merged commit 1381f52 into Azure:main Jan 30, 2025
145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants