Skip to content

use default k8s probe settings #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidgamero merged 8 commits into from
Feb 3, 2025
Merged

use default k8s probe settings #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c182c0f
Update draft.yaml
davidgamero Feb 3, 2025
c3e38de
Update draft.yaml
davidgamero Feb 3, 2025
a9778fe
Update draft.yaml
davidgamero Feb 3, 2025
533fab9
Update helm.yaml
davidgamero Feb 3, 2025
be47155
Update kustomize.yaml
davidgamero Feb 3, 2025
89e3944
Update manifest.yaml
davidgamero Feb 3, 2025
15a7c64
remove startup delays for specific tests
davidgamero Feb 3, 2025
54c6d51
update fixtures
davidgamero Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/fixtures/deployments/helm/charts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ readinessProbe:
startupProbe:
tcpSocket:
port: 80
periodSeconds: 1
timeoutSeconds: 3
failureThreshold: 1
periodSeconds: 10
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
initialDelaySeconds: 5
initialDelaySeconds: 0

nodeSelector: {}

Expand Down Expand Up @@ -110,4 +110,4 @@ securityContext:

envVars:

generatorLabel: draft
generatorLabel: draft
10 changes: 5 additions & 5 deletions pkg/fixtures/deployments/kustomize/base/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ spec:
startupProbe:
tcpSocket:
port: 80
periodSeconds: 1
timeoutSeconds: 3
failureThreshold: 1
periodSeconds: 10
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
initialDelaySeconds: 5
initialDelaySeconds: 0
securityContext:
seccompProfile:
type: RuntimeDefault
Expand Down Expand Up @@ -90,4 +90,4 @@ spec:
whenUnsatisfiable: ScheduleAnyway
labelSelector:
matchLabels:
app.kubernetes.io/name: testapp
app.kubernetes.io/name: testapp
10 changes: 5 additions & 5 deletions pkg/fixtures/deployments/manifest/manifests/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ spec:
startupProbe:
tcpSocket:
port: 80
periodSeconds: 1
timeoutSeconds: 3
failureThreshold: 1
periodSeconds: 10
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
initialDelaySeconds: 5
initialDelaySeconds: 0
securityContext:
seccompProfile:
type: RuntimeDefault
Expand Down Expand Up @@ -90,4 +90,4 @@ spec:
whenUnsatisfiable: ScheduleAnyway
labelSelector:
matchLabels:
app.kubernetes.io/name: testapp
app.kubernetes.io/name: testapp
8 changes: 4 additions & 4 deletions template/deployments/helm/draft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,23 +122,23 @@ variables:
kind: "kubernetesProbePeriod"
default:
disablePrompt: true
value: 1
value: 10
description: "kubernetes startup probe period in seconds"
versions: ">=0.0.1"
- name: "STARTUPTIMEOUT"
type: "int"
kind: "kubernetesProbeTimeout"
default:
disablePrompt: true
value: 3
value: 1
description: "kubernetes startup probe timeout in seconds"
versions: ">=0.0.1"
- name: "STARTUPFAILURETHRESHOLD"
type: "int"
kind: "kubernetesProbeThreshold"
default:
disablePrompt: true
value: 1
value: 3
description: "kubernetes startup probe failure threshold"
versions: ">=0.0.1"
- name: "STARTUPSUCCESSTHRESHOLD"
Expand All @@ -154,7 +154,7 @@ variables:
kind: "kubernetesProbeDelay"
default:
disablePrompt: true
value: 5
value: 0
description: "kubernetes startup probe initial delay in seconds"
versions: ">=0.0.1"
- name: "READINESSPERIOD"
Expand Down
8 changes: 4 additions & 4 deletions template/deployments/kustomize/draft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,23 +122,23 @@ variables:
kind: "kubernetesProbePeriod"
default:
disablePrompt: true
value: 1
value: 10
description: "kubernetes startup probe period in seconds"
versions: ">=0.0.1"
- name: "STARTUPTIMEOUT"
type: "int"
kind: "kubernetesProbeTimeout"
default:
disablePrompt: true
value: 3
value: 1
description: "kubernetes startup probe timeout in seconds"
versions: ">=0.0.1"
- name: "STARTUPFAILURETHRESHOLD"
type: "int"
kind: "kubernetesProbeThreshold"
default:
disablePrompt: true
value: 1
value: 3
description: "kubernetes startup probe failure threshold"
versions: ">=0.0.1"
- name: "STARTUPSUCCESSTHRESHOLD"
Expand All @@ -154,7 +154,7 @@ variables:
kind: "kubernetesProbeDelay"
default:
disablePrompt: true
value: 5
value: 0
description: "kubernetes startup probe initial delay in seconds"
versions: ">=0.0.1"
- name: "READINESSPERIOD"
Expand Down
8 changes: 4 additions & 4 deletions template/deployments/manifests/draft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,23 +122,23 @@ variables:
kind: "kubernetesProbePeriod"
default:
disablePrompt: true
value: 1
value: 10
description: "kubernetes startup probe period in seconds"
versions: ">=0.0.1"
- name: "STARTUPTIMEOUT"
type: "int"
kind: "kubernetesProbeTimeout"
default:
disablePrompt: true
value: 3
value: 1
description: "kubernetes startup probe timeout in seconds"
versions: ">=0.0.1"
- name: "STARTUPFAILURETHRESHOLD"
type: "int"
kind: "kubernetesProbeThreshold"
default:
disablePrompt: true
value: 1
value: 3
description: "kubernetes startup probe failure threshold"
versions: ">=0.0.1"
- name: "STARTUPSUCCESSTHRESHOLD"
Expand All @@ -154,7 +154,7 @@ variables:
kind: "kubernetesProbeDelay"
default:
disablePrompt: true
value: 5
value: 0
description: "kubernetes startup probe initial delay in seconds"
versions: ">=0.0.1"
- name: "READINESSPERIOD"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/clojure/helm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "8-jdk-alpine"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/clojure/kustomize.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "8-jdk-alpine"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/clojure/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "8-jdk-alpine"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/gradle/helm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "11-jre"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/gradle/kustomize.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "11-jre"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/gradle/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "11-jre"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/java/helm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "11-jre"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/java/kustomize.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "11-jre"
Expand Down
2 changes: 0 additions & 2 deletions test/integration/java/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ deployVariables:
value: "testapp"
- name: "IMAGENAME"
value: "host.minikube.internal:5001/testapp"
- name: "STARTUPINITIALDELAY"
value: 30
languageVariables:
- name: "VERSION"
value: "11-jre"
Expand Down
Loading