Skip to content

Add private cluster support for namespace creation/validation#495

Merged
Vidya2606 merged 3 commits intoAzure:mainfrom
bosesuneha:fix-namespace-check
Feb 5, 2025
Merged

Add private cluster support for namespace creation/validation#495
Vidya2606 merged 3 commits intoAzure:mainfrom
bosesuneha:fix-namespace-check

Conversation

@bosesuneha
Copy link
Member

Description

Please include the related issue if relevant, and motivation/context. Please also list any dependencies required for this change.

Fixes # (issue)
Feature # (details)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bosesuneha bosesuneha marked this pull request as draft February 5, 2025 06:01
@bosesuneha bosesuneha marked this pull request as ready for review February 5, 2025 07:52
Copy link
Contributor

@Vidya2606 Vidya2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Vidya2606 Vidya2606 merged commit 6f571da into Azure:main Feb 5, 2025
145 checks passed
@bosesuneha bosesuneha mentioned this pull request Feb 5, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants