Fix buffer_profile GCU validator to pass scope to rdma_config_update_validator#316
Merged
cyw233 merged 1 commit intoAzure:202405from Apr 22, 2026
Merged
Conversation
…validator validate_field_operation invokes validators as (scope, patch_element). buffer_profile_config_update_validator only took patch_element and called rdma_config_update_validator with one argument, causing TypeError on field-level BUFFER_PROFILE patches. Accept scope and forward both arguments. Signed-off-by: anamehra <anamehra@cisco.com>
anamehra
force-pushed
the
anamehra/rollback_fix_202405
branch
from
a5529bc to
5ca973f
Compare
Contributor
Author
|
Hi @cyw233 , please review. Thanks |
|
Passing for me as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anamehra anamehra@cisco.com
validate_field_operation invokes validators as (scope, patch_element). buffer_profile_config_update_validator only took patch_element and called rdma_config_update_validator with one argument, causing TypeError on field-level BUFFER_PROFILE patches. Accept scope and forward both arguments.
What I did
Fixed GCU config rollback for buffer profile for 202405
How I did it
Fixed buffer_profile_config_update_validator signature to include scope.
How to verify it
Run rollback tests as part of test_update_cable_length.py
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)