[action] [PR:4266] [console] add config console escape#320
Merged
lizhijianrd merged 1 commit intoAzure:202603from Apr 23, 2026
Merged
[action] [PR:4266] [console] add config console escape#320lizhijianrd merged 1 commit intoAzure:202603from
lizhijianrd merged 1 commit intoAzure:202603from
Conversation
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "closes #xxxx",
"fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
issue when the PR is merged.
If you are adding/modifying/removing any command or utility script, please also
make sure to add/modify/remove any unit tests from the tests
directory as appropriate.
If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
subcommand, or you are adding a new subcommand, please make sure you also
update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
your changes.
Please provide the following information:
-->
#### What I did
Add escape char config to console feature.
In CONFIG_DB, an optional new entry under CONSOLE_SWITCH, "console_mgmt", is added, "default_escape_char" as the key and we expect a lower case letter as value. Similarly, an optional new entry under CONSOLE_PORT, and then each line, "escape_char" as the key and we also expect a lower case letter as value.
Commands are:
1. config console default_escape (upper and lower case letters, or clear), e.g. config console default_escape k, config console default_escape B, config console default_escape clear.
2. config console escape [LINE_NUMBER] (upper and lower case letters, or clear), e.g. config console escape 6 C, config console escape 5 clear
3. show line --show-escape, e.g. show line --show-escape, show line -s -b
Connect command work as usual, except that it will add --escape <escape_char> in the underlying picocom command if it is configured.
Additionally,
1. some style change to old code to pass pre-commit check
2. unit tests for new functions
3. enhancement to old unit tests and its bug fix
#### How I did it
Implement them
#### How to verify it
Run the commands in dut.
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)
Collaborator
Author
|
Original PR: sonic-net/sonic-utilities#4266 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add escape char config to console feature.
In CONFIG_DB, an optional new entry under CONSOLE_SWITCH, "console_mgmt", is added, "default_escape_char" as the key and we expect a lower case letter as value. Similarly, an optional new entry under CONSOLE_PORT, and then each line, "escape_char" as the key and we also expect a lower case letter as value.
Commands are:
Connect command work as usual, except that it will add --escape <escape_char> in the underlying picocom command if it is configured.
Additionally,
How I did it
Implement them
How to verify it
Run the commands in dut.
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)