Skip to content

Add HOBO automatic Telescope scenario#1122

Merged
mingqishao merged 12 commits intomainfrom
minsha/202603/hobo-auto
Apr 17, 2026
Merged

Add HOBO automatic Telescope scenario#1122
mingqishao merged 12 commits intomainfrom
minsha/202603/hobo-auto

Conversation

@mingqishao
Copy link
Copy Markdown
Contributor

@mingqishao mingqishao commented Apr 7, 2026

periodically run test for AKS's HOBO Automatic cluster.

@mingqishao mingqishao marked this pull request as ready for review April 14, 2026 17:28
Copilot AI review requested due to automatic review settings April 14, 2026 17:28
@mingqishao mingqishao requested a review from liyu-ma as a code owner April 14, 2026 17:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new “HOBO automatic” perf-eval scenario for Azure, including Terraform inputs and an Azure DevOps scheduled pipeline to run the benchmark.

Changes:

  • Added Azure Terraform scenario inputs for hobo-automatic (tfvars + test inputs).
  • Added a scheduled Azure DevOps pipeline to run the scenario daily in australiaeast.
  • Configured clusterloader2 engine inputs and a small default benchmark matrix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
scenarios/perf-eval/hobo-automatic/terraform-test-inputs/azure.json Adds test input JSON for Azure scenario runs (run_id/region).
scenarios/perf-eval/hobo-automatic/terraform-inputs/azure.tfvars Adds Terraform variables defining the HOBO automatic AKS CLI configuration and parameters.
pipelines/perf-eval/Automatic Benchmark/hobo-automatic.yml Adds a scheduled pipeline to execute the HOBO automatic benchmark in Azure (australiaeast).

Comment thread pipelines/perf-eval/Automatic Benchmark/hobo-automatic.yml Outdated
Comment thread scenarios/perf-eval/hobo-automatic/terraform-inputs/azure.tfvars
Comment thread scenarios/perf-eval/hobo-automatic/terraform-test-inputs/azure.json Outdated
@liyu-ma
Copy link
Copy Markdown
Contributor

liyu-ma commented Apr 15, 2026

Code review

Found 1 issue:

  1. node_label_selector uses "karpenter.sh/nodepool=default" (no spaces around =), but every other pipeline in the repo uses "karpenter.sh/nodepool = default" (with spaces). Depending on how this value is parsed downstream, the missing spaces could cause the label selector to fail silently. At minimum it is an inconsistency worth aligning.

scale_down_timeout: "30m"
node_label_selector: "karpenter.sh/nodepool=default"

liyu-ma
liyu-ma previously approved these changes Apr 15, 2026
@mingqishao mingqishao merged commit 36e05b3 into main Apr 17, 2026
5 checks passed
@mingqishao mingqishao deleted the minsha/202603/hobo-auto branch April 17, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants