Conversation
vittoriasalim
requested review from
liyu-ma,
wonderyl and
xinWeiWei24
as code owners
| }""") | ||
|
|
||
| createClusterScript = """ | ||
| az cloud update --endpoint-resource-manager https://eastus2euap.management.azure.com/ |
There was a problem hiding this comment.
I don't think we need to set ARM endpoint anymore
| SUBSCRIPTION_ID, | ||
| CL2_POOL, | ||
| "Standard_D8S_v4", | ||
| 4, |
There was a problem hiding this comment.
I don't think you need 4 VMs for CL2?
| - Identifier: HighThroughputPodStartupLatency | ||
| Method: PodStartupLatency |
There was a problem hiding this comment.
Since we use kwok nodes, do we still want to measure startup latency?
| backoffLimit: 0 # Don't retry failed CL2 runs. | ||
| template: | ||
| spec: | ||
| initContainers: |
| @@ -0,0 +1,51 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
why not merge cl2-config.yaml into cl2.yaml?
| volumeMounts: | ||
| - mountPath: /override | ||
| name: cl2-override | ||
| - mountPath: /root/perf-tests/clusterloader2/testing/load/cl2-config.yaml |
There was a problem hiding this comment.
could you avoid using the same file name for /root/perf-tests/clusterloader2/testing/load/cl2-config.yaml and kcl/ccp_team/hyperscale_pod_scheduling/cl2-config.yaml. It's easy to get confused.
| operator: "Exists" | ||
| effect: "NoExecute" | ||
| tolerationSeconds: 900 | ||
| - key: "kwok.x-k8s.io/node" |
There was a problem hiding this comment.
I don't see a taint kwok.x-k8s.io/node, can this be removed?
| "node-lease-duration-seconds": "100" | ||
| "pod-play-stage-parallelism": "500" | ||
| }), | ||
| azure.AzCli( |
There was a problem hiding this comment.
I don't think you need AzCli if your script only uses kubectl - a Bash should do it. AzCli involves getting credential and do az login, which is not necessary since the pipeline already pulled the cluster config. Same for some other steps later in the pipeline.
| name: cl2-simple-deployment | ||
| namespace: clusterloader2 | ||
| data: | ||
| simple-deployment.yaml: | |
There was a problem hiding this comment.
you don't need another simple-deployment.yaml cl2 already has one https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/testing/load/modules/scheduler-throughput/simple-deployment.yaml
You can use RUN_ON_ARM_NODES override to allow it to run on kwok nodes. see
| "SkipLinuxAzSecPack": "true" | ||
| }, | ||
| "properties": { | ||
| "controlPlaneScalingProfile": {"scalingSize": "H4"}, |
There was a problem hiding this comment.
It is hardcoded as H4 while PR title says h2
| NODE_COUNT = 2000 | ||
| KWOK_NODES_PER_CONTROLLER = 100 | ||
| KWOK_POOL = "kwokpool" | ||
| KWOK_POOL_VM_SIZE = "Standard_D8_v3" |
There was a problem hiding this comment.
Do we need 8 cores? Would D4_v3 do well for us
| name: cl2 | ||
| namespace: clusterloader2 | ||
| spec: | ||
| completions: 1 |
3 participants
as title