Skip to content

Enhancement - Add option to add a state to an auth code url request#485

Open
tomneurobell wants to merge 2 commits into
AzureAD:mainfrom
tomneurobell:feat/add-state-to-request
Open

Enhancement - Add option to add a state to an auth code url request#485
tomneurobell wants to merge 2 commits into
AzureAD:mainfrom
tomneurobell:feat/add-state-to-request

Conversation

@tomneurobell

@tomneurobell tomneurobell commented May 22, 2024

Copy link
Copy Markdown

I have added another option to the AuthCodeURL function in the confidential package to allow for conveniently adding a state parameter to the request, this avoids the need to have to modify the URL output manually and improves DevEX.

Resolves issues #227 and #407

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomneurobell

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Comment thread apps/confidential/confidential.go
Comment thread apps/confidential/confidential.go
dcormier added a commit to dcormier/microsoft-authentication-library-for-go that referenced this pull request Jun 20, 2024
dcormier added a commit to dcormier/microsoft-authentication-library-for-go that referenced this pull request Jun 20, 2024
dcormier added a commit to dcormier/microsoft-authentication-library-for-go that referenced this pull request Jun 20, 2024
@tomneurobell

Copy link
Copy Markdown
Author

@rayluo Can I ask for a status update on this?
Is it ever going to be reviewed and merged?
We're up to 9 months now

@bgavrilMS bgavrilMS requested review from 4gust and removed request for rayluo February 17, 2026 11:50
return cca.base.AuthCodeURL(ctx, clientID, redirectURI, scopes, ap)
}

// WithState adds a user-generated state to the request.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// WithState adds a user-generated state to the request.
// WithState adds a user-generated state to the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants