pass on type info for props to forwardref to make typescript work for own props#18
Merged
brion-fuller merged 1 commit intoBBKolton:masterfrom Jul 29, 2021
bardoo:fix/typescript-support-for-props
Merged
pass on type info for props to forwardref to make typescript work for own props#18brion-fuller merged 1 commit intoBBKolton:masterfrom bardoo:fix/typescript-support-for-props
brion-fuller merged 1 commit intoBBKolton:masterfrom
bardoo:fix/typescript-support-for-props
Conversation
Contributor
Author
|
Hi again. Been a couple of weeks. Not sure how to get a review of this PR. @BBKolton tagging you since you're the owner. Any tips? |
Collaborator
|
Really sorry for the delay. I will looking more into this |
|
There are some evolution about this PR? |
|
@brion-fuller Any update on this. It looks like a really promising package to use as teams at my job are moving to web components for UI elements we're including into our portal. |
brion-fuller
approved these changes
Jul 26, 2021
Collaborator
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for typescript to solve issue with own props: #15.
All seems to be working in the test-app.
I know that #17 will fix this issue, but not sure when it would be done, so I thought it would be nice to just do this on it's own as it's probably is affecting a few people. @BBKolton