Add workaround for creating sw.js file for embroider project#123
Open
colenso wants to merge 3 commits intoBBVAEngineering:masterfrom
Open
Add workaround for creating sw.js file for embroider project#123colenso wants to merge 3 commits intoBBVAEngineering:masterfrom
colenso wants to merge 3 commits intoBBVAEngineering:masterfrom
Conversation
Author
|
@adrigzr Would appreciate some 👀 here as well. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've taken the inspiration from prember which mentioned that embroider based projects don't support postprocessTree hook of type 'all' and hence we need a way to manually call the function that generates the file.
This fixes #122