Open
Conversation
BaeJinho4028
reviewed
Apr 3, 2026
BaeJinho4028
left a comment
BaeJinho4028
left a comment
There was a problem hiding this comment.
줄넘김과 공백을 잘 신경쓰시면 좋을 것 같습니당
간단한 리뷰 남깁니담. 고생하셨어요
| String a = in.nextLine(); | ||
| List<Car> cars = new ArrayList<>(); | ||
| for (String name : a.split(",")) { | ||
| if (name.isEmpty()) {throw new IllegalArgumentException("왜안적음");} |
| } | ||
| } | ||
|
|
||
| public class Application { |
There was a problem hiding this comment.
Application에 로직이 많이 몰려 있어서 입력/검증/실행/출력을 메소드 또는 클래스로 분리하면 가독성이 더 좋아질 것 같습니다.
| } | ||
| } | ||
|
|
||
| //조아요 조아요 |
Comment on lines
+7
to
+8
| String name; | ||
| int moveCount; |
There was a problem hiding this comment.
rivate으로 두고 getter를 통해 접근하도록 하면 캡슐화 측면에서 좋아질 것이라고 생각합니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.