WIP: new plot for checking/investigating input ASTs#652
Draft
cmurray-astro wants to merge 5 commits intoBEAST-Fitting:masterfrom
Draft
WIP: new plot for checking/investigating input ASTs#652cmurray-astro wants to merge 5 commits intoBEAST-Fitting:masterfrom
cmurray-astro wants to merge 5 commits intoBEAST-Fitting:masterfrom
Conversation
Member
|
I do think it is useful - thanks for opening this PR. I think it does require some documentation to explain the plots and what users should look for. Also, it would be good to get this into the main.py script in the base beast directory so that this script can be called with |
Member
|
Ping. This feels like a stale PR. With no movement in the near future, I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a new routine to plot some sanity-check level diagnostics for the input ASTs, ideally to be used (along with plot_ast_histogram) to make sure that the input ASTs look good before shipping them off to be processed. So far, this includes plotting their spatial distribution against the source density image (left, below) and, for all filters in the set, plotting CMDs as a function of source density (right, below; currently done in contours to simplify the plot, and entirely-overlapping contours is what we're looking for... i.e. all ASTs are replicated in the same way across all source density bins).
An example of what this looks like right now is below.
My questions are: is this useful? If so, what else should be included? Or how should the formatting be improved? Should I split this into individual plots (my original thought was to make a one-stop-shop for sanity checks).
