Merge functions that react to state change#360
Open
EZoni wants to merge 4 commits intoBLAST-AI-ML:mainfrom
Open
Merge functions that react to state change#360EZoni wants to merge 4 commits intoBLAST-AI-ML:mainfrom
EZoni wants to merge 4 commits intoBLAST-AI-ML:mainfrom
Conversation
9 tasks
There was a problem hiding this comment.
Pull request overview
This pull request refactors state change handling by consolidating three separate callback functions into a single unified handler. The change is part of preparatory work extracted from PR #356, which adds a control to select the type of inputs displayed in the dashboard.
Changes:
- Merged three state change handlers (
update_on_change_experiment,update_on_change_model,update_on_change_others) into a singleresetfunction - The new function uses conditional branching to determine appropriate reset actions based on which state variable changed
- All original functionality is preserved with identical reset behavior for each state variable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Merge the separate functions
update_on_change_experimentupdate_on_change_modelupdate_on_change_othersinto a single function
reset, which decides what to reset after inspectingstate.modified_keys.Notes