Skip to content

Updated installation scripts and docker install. Fixed samplesheet parse and using application folder samba param#389

Merged
saramonzon merged 34 commits intoBU-ISCIII:developfrom
saramonzon:develop
Feb 24, 2026
Merged

Updated installation scripts and docker install. Fixed samplesheet parse and using application folder samba param#389
saramonzon merged 34 commits intoBU-ISCIII:developfrom
saramonzon:develop

Conversation

@saramonzon
Copy link
Member

@saramonzon saramonzon commented Feb 24, 2026

High-level summary

This PR introduces a set of improvements to the Docker runtime handling, database migrations workflow, installation scripts, Samba configuration, and documentation.
Closes #387


Docker Runtime & Configuration

  • Copy Docker runtime to tmp when path is outside the repository
  • Copy Docker runtime into the repository when required for external paths
  • Renamed docker-compose.yml to docker-compose.test.yml
  • Fixed and improved passing of git revision to the Dockerfile
  • Ensured configuration files are accessible from within the container
  • Updated Docker test install settings name
  • Switched IP to Docker internal networking for proper local execution
  • Opened Docker network to allow connection to localhost MySQL (not required if MySQL is external)

Installation & Scripts

  • Applied multiple fixes in docker_install.sh
  • Added comment in install.sh clarifying the second migrate command
  • Fixed getopts handling for script-before option
  • Added support for script-before and script-after migration hooks
  • Fixed function not using application folder path correctly
  • Fixed disk utilization check to correctly resolve application folder
  • Removed --exclude migrations from rsync
  • Reverted unintended change affecting behavior

Database & Migrations

  • Removed migrations from .gitignore
  • Removed app-based .gitignore
  • Committed baseline migration files
  • Added new migrations for develop changes
  • Dropped foreign key before removing run_process_id_id
  • Added required export for library pool many-to-many relation
  • Added developer notes on how to create migration files
  • Added documentation describing migration scripts and related versions
  • Updated upgrade scripts documentation with execution order information

Samba Configuration

  • Updated Samba configuration for test data
  • Fixed shared folder resolution when Samba application folder is present in configuration

Parsing & Application Fixes

  • Fixed samplesheet parsing logic

Documentation & Messaging

  • Clarified documentation across README and related docs
  • Improved user-facing messages
  • General documentation improvements for clarity and consistency

Related Issues

N/A

Copy link
Collaborator

@Aberdur Aberdur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@saramonzon saramonzon merged commit df02ecf into BU-ISCIII:develop Feb 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants