Skip to content

Add support for new sequencer, improve tests and logging, and enhance container robustness#392

Merged
saramonzon merged 22 commits intoBU-ISCIII:developfrom
saramonzon:develop
Mar 17, 2026
Merged

Add support for new sequencer, improve tests and logging, and enhance container robustness#392
saramonzon merged 22 commits intoBU-ISCIII:developfrom
saramonzon:develop

Conversation

@saramonzon
Copy link
Member

Summary

This PR introduces support for a new sequencing machine, improves testing infrastructure, enhances logging consistency, and strengthens container deployment robustness. It also addresses multiple issues related to crontab behavior, sample sheet parsing, and test reliability.


Test Infrastructure

  • Added new test coverage for the new sequencing machine
  • Removed nologin user from tests
  • Fixed multiple issues in tests after new machine inclusion
  • Disabled mail sending on error in test configuration
  • Added groups to admin user in test setup
  • Added checks to ensure the latest code is installed in containers during testing

Sequencer & Data Handling

  • Added support for new sequencer in initial install tables
  • Fixed run folder naming for the new machine
  • Added support for new SampleSheet format and updated demultiplexing stats path
  • Adapted parsing of run info and run parameters for new MiSeq tags

Logging & Debugging

  • Fixed logger inconsistency causing missing logs in update_crontab
  • Added additional logging to improve debugging
  • Improved error messaging when interop graphs are not generated
  • Added better stale image diagnosis

Container & Deployment Improvements

  • Improved safety of rootless Podman containers
  • Added correct permissions when copying demo data into containers
  • Added git revision reference to ensure current code is used during testing
  • Installed gnuplot via EPEL (required as it is not available in UBI9)

Pipeline & Tooling

  • Reverted to using interop CLI for graph generation

Related Issues

Closes #390 — Fix logger inconsistency preventing errors from being written to update_crontab log
Closes #388 — Create test data for iskylims for new sequencer and SampleSheet v2 support
Closes #387 — Update iskylims crontab to look up Runs for new sequencer

Aberdur
Aberdur previously approved these changes Mar 17, 2026
Copy link
Collaborator

@Aberdur Aberdur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@saramonzon saramonzon merged commit ab26578 into BU-ISCIII:develop Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants