Script arguments#10
Merged
Merged
Conversation
benrencher
approved these changes
Jun 1, 2026
benrencher
left a comment
benrencher
left a comment
Contributor
There was a problem hiding this comment.
I didn't see a test that ensures that two jobs with duplicate args results in only one command line in the sudoers script, but I'm not sure we must have a test for it. I'll leave it up to you to decide whether to include one before merging or not. Everything else looks good to me.
Contributor
There was a problem hiding this comment.
Should there be a test to make sure two jobs with the same args does not create duplicate commands in the resulting bash script? This is mentioned in a comment in src/fetch_runner/cli.py but I don't see a test for it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.